Skip to content

feat: log long-lived connections acceptance #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Apr 8, 2025
+351 −24
Merged

feat: log long-lived connections acceptance #17219

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
0e397ed
initial implementation of RequestLoggerContext and example usage in P…
ibetitsmike Apr 2, 2025
c384706
fix empty RequestLoggerContext
ibetitsmike Apr 2, 2025
686f4db
referenced httplog while creating RequestLoggerContext
ibetitsmike Apr 2, 2025
7edb8c3
refactored fields extension on the logger
ibetitsmike Apr 2, 2025
5feb4e4
fixed log formatting
ibetitsmike Apr 2, 2025
7500ef5
typo comment fix
ibetitsmike Apr 2, 2025
66e2c3e
added logging to long lived connection opening functions
ibetitsmike Apr 2, 2025
4e5f36e
added logging to other places
ibetitsmike Apr 2, 2025
b7822b3
updated comments
ibetitsmike Apr 3, 2025
a772430
renamed context fetcher
ibetitsmike Apr 3, 2025
2a1dbe3
refactored logging in the logger middleware and added tests for logger
ibetitsmike Apr 3, 2025
5a0fa05
removed unecessary helpers
ibetitsmike Apr 3, 2025
30bb53d
added test for an http request
ibetitsmike Apr 3, 2025
89e987e
linting fixes
ibetitsmike Apr 3, 2025
1649116
added handling of internal test circumventing RequestLoggerContext in…
ibetitsmike Apr 3, 2025
7ea2dd6
reverted the original behavior of logging WARN on Status Code >=500
ibetitsmike Apr 3, 2025
338fd20
refactored logger to remove extending it with fields permanently
ibetitsmike Apr 4, 2025
2708286
Removed nil checks when fetching RequestLogger
ibetitsmike Apr 6, 2025
ca3c4d3
refactored tests to use a fakesink to verify the written messages
ibetitsmike Apr 6, 2025
dfa2f4f
added WebSocket test to verify early logging
ibetitsmike Apr 6, 2025
845ff0f
fix lint for response body leak
ibetitsmike Apr 6, 2025
1f7acfb
reverted bodyclose lint fix
ibetitsmike Apr 6, 2025
58aa736
fix for race condition in the test
ibetitsmike Apr 6, 2025
2c63b32
linter fixes
ibetitsmike Apr 6, 2025
d268a3c
actually added logging early to test early logging
ibetitsmike Apr 7, 2025
8f550c5
added a WaitGroup in logger internal tests to remove the race condition
ibetitsmike Apr 7, 2025
81e1527
refactor after code review
ibetitsmike Apr 7, 2025
b9e2b61
added checking the logger fields in the test
ibetitsmike Apr 7, 2025
deb1a41
refactored mock request logger to fit current codebase
ibetitsmike Apr 7, 2025
09e46d0
added mocked files to Makefile
ibetitsmike Apr 7, 2025
9b16cf9
format fix
ibetitsmike Apr 7, 2025
2e331a3
fixed path in Makefile
ibetitsmike Apr 7, 2025
7e9f083
fixed Makefile path
ibetitsmike Apr 7, 2025
b82776f
fixed nested path in Makefile
ibetitsmike Apr 7, 2025
3d44727
Merge branch 'main' into mike/16904-request-logging-on-long-lived-con…
ibetitsmike Apr 8, 2025
cb118a9
added additional checks
ibetitsmike Apr 8, 2025
754cee6
refactored the WebSocket test to actually read and close the connection
ibetitsmike Apr 8, 2025
d28f2bd
Merge branch 'main' into mike/16904-request-logging-on-long-lived-con…
ibetitsmike Apr 8, 2025
57a49d5
Merge branch 'main' into mike/16904-request-logging-on-long-lived-con…
ibetitsmike Apr 8, 2025
cb130de
Merge branch 'main' into mike/16904-request-logging-on-long-lived-con…
ibetitsmike Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed nested path in Makefile
  • Loading branch information
@ibetitsmike
ibetitsmike committed Apr 7, 2025
commit b82776f9e2c3e476049792a7686136571891dfb6
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ agent/agentcontainers/acmock/acmock.go: agent/agentcontainers/containers.go
touch "$@"

coderd/httpmw/loggermock/loggermock.go: coderd/httpmw/logger.go
go generate ./coderd/httpmw/loggermock/loggermock/
go generate ./coderd/httpmw/loggermock/
touch "$@"

agent/agentcontainers/dcspec/dcspec_gen.go: \
Expand Down
Loading