Skip to content

fix: fix closeMutex unlock bug #17259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 4, 2025

Fixes coder/internal#550

Classic return before unlocking bug.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis requested review from johnstcn and mafredri April 4, 2025 10:13
@spikecurtis spikecurtis marked this pull request as ready for review April 4, 2025 10:13
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@spikecurtis spikecurtis merged commit 42e5d71 into main Apr 4, 2025
41 checks passed
Copy link
Contributor Author

Merge activity

  • Apr 4, 6:29 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/internal-550-agent-shutdown branch April 4, 2025 10:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: coderd: TestWorkspaceWatcher
2 participants