Skip to content

feat: support --hostname-suffix flag on coder ssh #17279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

feat: support --hostname-suffix flag on coder ssh #17279

merged 2 commits into from
Apr 7, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 7, 2025 •
edited
Loading

Adds hostname-suffix flag to coder ssh command for use in SSH Config ProxyCommands.

Also enforces that Coder server doesn't start the suffix with a dot.

part of: #16828

@spikecurtis Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Apr 7, 2025
Merged
@spikecurtis spikecurtis marked this pull request as ready for review April 7, 2025 13:15
johnstcn
johnstcn approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on the cmd docs, but otherwise LGTM!

@spikecurtis spikecurtis removed the request for review from bcpeinhardt April 7, 2025 17:04
@spikecurtis spikecurtis force-pushed the spike/host-suffix/ssh-hostname-suffix-flag branch from 34de3bc to c45e4db Compare April 7, 2025 17:18
@spikecurtis spikecurtis merged commit d312e82 into main Apr 7, 2025
37 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 7, 1:33 PM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/host-suffix/ssh-hostname-suffix-flag branch April 7, 2025 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @mafredri @johnstcn