Skip to content

feat: modify config-ssh to set the host suffix #17280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

feat: modify config-ssh to set the host suffix #17280

merged 3 commits into from
Apr 8, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 7, 2025 •
edited
Loading

Wires up config-ssh command to use a hostname suffix if configured.

part of: #16828

e.g. coder config-ssh --hostname-suffix spiketest gives:

# ------------START-CODER-----------
# This section is managed by coder. DO NOT EDIT.
#
# You should not hand-edit this section unless you are removing it, all
# changes will be lost when running "coder config-ssh".
#
# Last config-ssh options:
# :hostname-suffix=spiketest
#
Host coder.* *.spiketest
        ConnectTimeout=0
        StrictHostKeyChecking=no
        UserKnownHostsFile=/dev/null
        LogLevel ERROR
        ProxyCommand /home/coder/repos/coder/build/coder_config_ssh --global-config /home/coder/.config/coderv2 ssh --stdio --ssh-host-prefix coder. --hostname-suffix spiketest %h
# ------------END-CODER------------

@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Apr 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Apr 7, 2025
Merged
@spikecurtis spikecurtis marked this pull request as ready for review April 7, 2025 13:18
mafredri
mafredri approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but otherwise LGTM 👍🏻

johnstcn
johnstcn reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one clarification regarding having both prefix and suffix enabled and expected behaviour / testing. Does it make sense to have both of these enabled?

@spikecurtis spikecurtis removed the request for review from bcpeinhardt April 7, 2025 17:17
@spikecurtis spikecurtis force-pushed the spike/host-suffix/ssh-hostname-suffix-flag branch from 34de3bc to c45e4db Compare April 7, 2025 17:18
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-uses-host-suffix branch from 2cac087 to 237f8e4 Compare April 7, 2025 17:18
@spikecurtis spikecurtis changed the base branch from spike/host-suffix/ssh-hostname-suffix-flag to graphite-base/17280 April 7, 2025 17:33
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-uses-host-suffix branch from 237f8e4 to 0ae03f3 Compare April 7, 2025 17:33
@spikecurtis spikecurtis force-pushed the graphite-base/17280 branch from c45e4db to d312e82 Compare April 7, 2025 17:33
@graphite-app graphite-app bot changed the base branch from graphite-base/17280 to main April 7, 2025 17:34
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-uses-host-suffix branch from 0ae03f3 to 283830c Compare April 7, 2025 17:34
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-uses-host-suffix branch from 283830c to b78738c Compare April 8, 2025 07:38
@spikecurtis spikecurtis merged commit 9eeb506 into main Apr 8, 2025
35 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 8, 3:48 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/host-suffix/config-ssh-uses-host-suffix branch April 8, 2025 07:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali left review comments

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spikecurtis @mafredri @johnstcn @matifali