fix(site): resolve all Array.prototype.toSorted and Array.prototype.sort bugs
#17307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Apr 9, 2025
| key={usage.slug} | ||
| css={{ display: "flex", gap: 24, alignItems: "center" }} | ||
| > | ||
| {validUsage.map((usage, i) => { |
There was a problem hiding this comment.
None of the code content changed here. The indentation only changed because I moved the .sort call up, to make it more obvious that it wasn't causing any harmful mutations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16759
Changes made
Array.prototype.toSortedwithArray.prototype.sortto provide better support for older browsersArray.prototype.sortcalls where necessary to remove risks of mutation render bugs.sortcalls are harmless and don't have any risks