Skip to content

fix(site): resolve all Array.prototype.toSorted and Array.prototype.sort bugs #17307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

fix(site): resolve all Array.prototype.toSorted and Array.prototype.sort bugs #17307

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fe4644
fix: remove all Array.prototype.toSorted calls
Parkreiner Apr 9, 2025
d08ab30
fix: remove all accidental render mutations
Parkreiner Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: remove all Array.prototype.toSorted calls
  • Loading branch information
@Parkreiner
Parkreiner committed Apr 9, 2025
commit 0fe46448fe7ba6a393ef91507636992f14cd68b9
2 changes: 1 addition & 1 deletion site/src/modules/dashboard/Navbar/proxyUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export function sortProxiesByLatency(
proxies: Proxies,
latencies: ProxyLatencies,
) {
return proxies.toSorted((a, b) => {
return [...proxies].sort((a, b) => {
const latencyA = latencies?.[a.id]?.latencyMS ?? Number.POSITIVE_INFINITY;
const latencyB = latencies?.[b.id]?.latencyMS ?? Number.POSITIVE_INFINITY;
return latencyA - latencyB;
Expand Down