Skip to content

feat: create dynamic parameter component #17351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 16, 2025
Merged

feat: create dynamic parameter component #17351

merged 13 commits into from
Apr 16, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Apr 10, 2025 •
edited
Loading

  • Create DynamicParameter component and test with locally run preview websocket.
  • Adapt CreateWorkspacePageExperimental to work with PreviewParameter instead of TemplateVersionParameter
  • Small changes to checkbox, multi-select combobox and radiogroup

The websocket implementation is temporary for testing purpose with a locally run preview websocket

@jaaydenh jaaydenh self-assigned this Apr 10, 2025
@jaaydenh jaaydenh force-pushed the jaaydenh/dynamic-parameter-component branch 2 times, most recently from 80e9dbd to 250ee53 Compare April 11, 2025 20:20
@jaaydenh jaaydenh force-pushed the jaaydenh/dynamic-parameter-component branch from 250ee53 to dd5147d Compare April 11, 2025 20:53
@jaaydenh jaaydenh requested a review from aslilac April 11, 2025 21:02
@jaaydenh jaaydenh marked this pull request as ready for review April 11, 2025 21:02
aslilac
aslilac reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the current implementation of useWebSocket is not meant to be a production ready React WebSocket binding, we should make that a lot clearer. it's half actually connecting to a websocket and half just using testdata? I'm confused on what it really wants to be

@jaaydenh jaaydenh requested a review from aslilac April 15, 2025 17:01
@jaaydenh jaaydenh force-pushed the jaaydenh/dynamic-parameter-component branch from 84c4abe to b7d0d32 Compare April 15, 2025 17:37
@jaaydenh jaaydenh force-pushed the jaaydenh/dynamic-parameter-component branch from 762aa3a to 2a35fe2 Compare April 15, 2025 19:14
@jaaydenh jaaydenh merged commit 1db70be into main Apr 16, 2025
34 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/dynamic-parameter-component branch April 16, 2025 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaaydenh @aslilac