Skip to content

feat: create dynamic parameter component #17351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 16, 2025
+760 −117
Merged

feat: create dynamic parameter component #17351

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1d32dbe
feat: create dynamic parameter component
jaaydenh Apr 10, 2025
5b1d5b4
fix: format
jaaydenh Apr 11, 2025
4516af2
chore: cleanup, update validation
jaaydenh Apr 11, 2025
5784127
chore: update for types from typesGenerated
jaaydenh Apr 11, 2025
dd5147d
fix: remove filters
jaaydenh Apr 11, 2025
3b8d5a5
chore: remove unused typesParameter.ts
jaaydenh Apr 11, 2025
25c7d3c
fix: use options instead of defaultOptions to set option values
jaaydenh Apr 12, 2025
1976720
fix: updates for PR review
jaaydenh Apr 15, 2025
2931256
fix: format
jaaydenh Apr 15, 2025
07632b8
fix: update to use useDebouncedFunction
jaaydenh Apr 15, 2025
b7d0d32
fix: remove websocket code
jaaydenh Apr 15, 2025
2a35fe2
chore: updates for PR review
jaaydenh Apr 15, 2025
fa3caf1
Merge branch 'main' into jaaydenh/dynamic-parameter-component
jaaydenh Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update to use useDebouncedFunction
  • Loading branch information
@jaaydenh
jaaydenh committed Apr 15, 2025
commit 07632b87c21e48773c2cbd5fda68e9047408e0ed
98 changes: 46 additions & 52 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { Stack } from "components/Stack/Stack";
import { Switch } from "components/Switch/Switch";
import { UserAutocomplete } from "components/UserAutocomplete/UserAutocomplete";
import { type FormikContextType, useFormik } from "formik";
import { useDebouncedFunction } from "hooks/debounce";
import { ArrowLeft } from "lucide-react";
import {
DynamicParameter,
Expand Down Expand Up @@ -209,67 +210,60 @@ export const CreateWorkspacePageViewExperimental: FC<
parameters,
]);

const [debouncedTimer, setDebouncedTimer] = useState<ReturnType<
typeof setTimeout
> | null>(null);

const handleChange = async (
value: string,
parameterField: string,
const sendDynamicParamsRequest = (
parameter: PreviewParameter,
value: string,
) => {
// Update form value immediately for all types
await form.setFieldValue(parameterField, {
name: parameter.form_type,
value,
const formInputs = Object.fromEntries(
form.values.rich_parameter_values?.map((value) => {
return [value.name, value.value];
}) ?? [],
);
// Update the input for the changed parameter
formInputs[parameter.name] = value;

setWSResponseId((prevId) => {
const newId = prevId + 1;
const request: DynamicParametersRequest = {
id: newId,
inputs: formInputs,
};
sendMessage(request);
return newId;
});
};

// Create the request object
const createRequest = () => {
const newInputs = Object.fromEntries(
form.values.rich_parameter_values?.map((value) => {
return [value.name, value.value];
}) ?? [],
);
// Update the input for the changed parameter
newInputs[parameter.name] = value;

setWSResponseId((prevId) => {
const newId = prevId + 1;
const request: DynamicParametersRequest = {
id: newId,
inputs: newInputs,
};
sendMessage(request);
return newId;
const { debounced: handleChangeDebounced } = useDebouncedFunction(
async (
parameter: PreviewParameter,
parameterField: string,
value: string,
) => {
await form.setFieldValue(parameterField, {
name: parameter.form_type,
value,
});
};

// Clear any existing timer
if (debouncedTimer) {
clearTimeout(debouncedTimer);
}
sendDynamicParamsRequest(parameter, value);
},
500,
);

// For input type, debounce the sendMessage
if (parameter.form_type === "input") {
const timer = setTimeout(() => {
createRequest();
}, 1050);
setDebouncedTimer(timer);
const handleChange = async (
parameter: PreviewParameter,
parameterField: string,
value: string,
) => {
if (parameter.form_type === "input" || parameter.form_type === "textarea") {
handleChangeDebounced(parameter, parameterField, value);
} else {
// For all other form control types (checkbox, select, etc.), send immediately
createRequest();
await form.setFieldValue(parameterField, {
name: parameter.form_type,
value,
});
sendDynamicParamsRequest(parameter, value);
}
};

useEffect(() => {
return () => {
if (debouncedTimer) {
clearTimeout(debouncedTimer);
}
};
}, [debouncedTimer]);

return (
<>
<div className="absolute sticky top-5 ml-10">
Expand Down Expand Up @@ -493,7 +487,7 @@ export const CreateWorkspacePageViewExperimental: FC<
key={parameter.name}
parameter={parameter}
onChange={(value) =>
handleChange(value, parameterField, parameter)
handleChange(parameter, parameterField, value)
}
disabled={isDisabled}
isPreset={isPresetParameter}
Expand Down
Loading