Skip to content

feat: add IsCoderConnectRunning to workspacesdk #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 11, 2025

Adds IsCoderConnectRunning() to the workspacesdk. This will support the coder CLI being able to use CoderConnect when it's running.

part of #16828

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis marked this pull request as ready for review April 11, 2025 12:32
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ICYMI (as I did), we still need to add HostnameSuffix to the generic DNS record

@spikecurtis
Copy link
Contributor Author

👍

ICYMI (as I did), we still need to add HostnameSuffix to the generic DNS record

Added this in #17335 during a merge after you already reviewed. Sorry I didn't point it out.

@spikecurtis spikecurtis merged commit e5ce382 into main Apr 14, 2025
40 of 41 checks passed
@spikecurtis spikecurtis deleted the spike/host-suffix/is-coder-connect-running branch April 14, 2025 05:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants