feat: implement UI for top level dynamic parameters diagnostics #17394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaaydenh
commented
Apr 14, 2025
|
is this one ready for review? the diff is kind of all over the place. it looks like you might've hit a rebase error or something. there are a bunch of commits duplicated from main and it's messing with things. |
a39b095 to
e04ce2f
Compare
@aslilac it needed a rebase, it should ready to review now |
a230dec to
001944c
Compare
aslilac
approved these changes
Apr 16, 2025
266620a to
440fedc
Compare
…com/coder/coder into jaaydenh/dynamic-params-diagnostics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.