Skip to content

feat: implement UI for top level dynamic parameters diagnostics #17394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Apr 16, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
7b61485
feat: create dynamic parameter component
jaaydenh Apr 10, 2025
f5d4a1c
fix: format
jaaydenh Apr 11, 2025
0fc4289
chore: cleanup, update validation
jaaydenh Apr 11, 2025
d109874
chore: update for types from typesGenerated
jaaydenh Apr 11, 2025
7c13eb7
fix: remove filters
jaaydenh Apr 11, 2025
4290284
chore: remove unused typesParameter.ts
jaaydenh Apr 11, 2025
74084fb
fix: updates for PR review
jaaydenh Apr 15, 2025
05adc15
fix: format
jaaydenh Apr 15, 2025
b2c662a
fix: remove websocket code
jaaydenh Apr 15, 2025
2da7d99
feat: connect to dynamic parameters websocket
jaaydenh Apr 14, 2025
98dfee2
chore: cleanup
jaaydenh Apr 14, 2025
d1ada89
fix: set initial values
jaaydenh Apr 14, 2025
e04ce2f
fix: fix commit
jaaydenh Apr 16, 2025
a6f480d
fix: fix rebase issues
jaaydenh Apr 16, 2025
2613100
chore: update valid value methods
jaaydenh Apr 16, 2025
1e66a71
chore: onError is required
jaaydenh Apr 16, 2025
9a9201e
chore: display websocket error in UI
jaaydenh Apr 16, 2025
1777ca9
fix: format
jaaydenh Apr 16, 2025
d7e46ff
feat: create dynamic parameter component
jaaydenh Apr 10, 2025
946d27a
chore: cleanup, update validation
jaaydenh Apr 11, 2025
c59a546
chore: update for types from typesGenerated
jaaydenh Apr 11, 2025
82a4733
fix: remove filters
jaaydenh Apr 11, 2025
c1cc222
chore: remove unused typesParameter.ts
jaaydenh Apr 11, 2025
ef389a9
feat: connect to dynamic parameters websocket
jaaydenh Apr 14, 2025
d21b83f
chore: cleanup
jaaydenh Apr 14, 2025
8c5be29
feat: enable top level diagnostics display
jaaydenh Apr 14, 2025
0658c35
fix: remove useWebsocket.ts
jaaydenh Apr 16, 2025
001944c
fix: add missing icons
jaaydenh Apr 16, 2025
00d6c32
fix: updates for PR review
jaaydenh Apr 16, 2025
57377b5
feat: create dynamic parameter component
jaaydenh Apr 10, 2025
ee37ae5
chore: cleanup, update validation
jaaydenh Apr 11, 2025
951bf12
chore: update for types from typesGenerated
jaaydenh Apr 11, 2025
de71716
fix: remove filters
jaaydenh Apr 11, 2025
193702a
chore: remove unused typesParameter.ts
jaaydenh Apr 11, 2025
c9608b4
fix: updates for PR review
jaaydenh Apr 15, 2025
cd09e42
fix: format
jaaydenh Apr 15, 2025
1a825b2
fix: remove websocket code
jaaydenh Apr 15, 2025
81d4a2b
fix: fix commit
jaaydenh Apr 16, 2025
c486af1
feat: create dynamic parameter component
jaaydenh Apr 10, 2025
53f1c22
chore: cleanup, update validation
jaaydenh Apr 11, 2025
7bcd18d
chore: update for types from typesGenerated
jaaydenh Apr 11, 2025
d6a4fde
fix: remove filters
jaaydenh Apr 11, 2025
ddd58da
chore: remove unused typesParameter.ts
jaaydenh Apr 11, 2025
ed981c6
feat: connect to dynamic parameters websocket
jaaydenh Apr 14, 2025
8d6ba96
chore: cleanup
jaaydenh Apr 14, 2025
99d4c3a
feat: enable top level diagnostics display
jaaydenh Apr 14, 2025
3ba83c9
fix: remove useWebsocket.ts
jaaydenh Apr 16, 2025
1555961
fix: add missing icons
jaaydenh Apr 16, 2025
7a34145
Merge branch 'jaaydenh/dynamic-params-diagnostics' of https://github.…
jaaydenh Apr 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: format
  • Loading branch information
jaaydenh committed Apr 16, 2025
commit cd09e4291aa923f1395cbcf7dac942db35ccd940
46 changes: 46 additions & 0 deletions .cursor/rules/frontend-dev.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
---
description: Frontend dev with React, Typescript, shadcn and Tailwind
globs:
alwaysApply: false
---

// TypeScript React .cursorrules

// Prefer functional components

const preferFunctionalComponents = true;

// TypeScript React best practices

const typescriptReactBestPractices = [
"Use React.FC for functional components with props",
"Utilize useState and useEffect hooks for state and side effects",
"Implement proper TypeScript interfaces for props and state",
"Use React.memo for performance optimization when needed",
"Implement custom hooks for reusable logic",
"Utilize TypeScript's strict mode",
];

// Folder structure

const folderStructure = `
src/
components/
hooks/
pages/
utils/
App.tsx
index.tsx
`;

// Additional instructions

const additionalInstructions = `
1. Use .tsx extension for files with JSX
2. Implement strict TypeScript checks
3. Utilize React.lazy and Suspense for code-splitting
4. Use type inference where possible
5. Implement error boundaries for robust error handling
6. Follow React and TypeScript best practices and naming conventions
7. Use ESLint with TypeScript and React plugins for code quality
`;
28 changes: 28 additions & 0 deletions site/src/components/Slider/Slider.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
"use client";

import * as SliderPrimitive from "@radix-ui/react-slider";
import * as React from "react";

import { cn } from "utils/cn";

const Slider = React.forwardRef<
React.ElementRef<typeof SliderPrimitive.Root>,
React.ComponentPropsWithoutRef<typeof SliderPrimitive.Root>
>(({ className, ...props }, ref) => (
<SliderPrimitive.Root
ref={ref}
className={cn(
"relative flex w-full touch-none select-none items-center h-1.5",
className,
)}
{...props}
>
<SliderPrimitive.Track className="relative h-1.5 w-full grow overflow-hidden rounded-full bg-content-secondary">
<SliderPrimitive.Range className="absolute h-full bg-content-primary" />
</SliderPrimitive.Track>
<SliderPrimitive.Thumb className="block h-4 w-4 rounded-full border border-solid border-content-primary bg-surface-primary shadow transition-colors focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:pointer-events-none disabled:opacity-50" />
</SliderPrimitive.Root>
));
Slider.displayName = SliderPrimitive.Root.displayName;

export { Slider };