Skip to content

feat: enable masking password inputs instead of blocking echo #17469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 24, 2025
Merged

feat: enable masking password inputs instead of blocking echo #17469

merged 13 commits into from
Apr 24, 2025

Conversation

ibetitsmike
Copy link
Contributor

@ibetitsmike ibetitsmike commented Apr 18, 2025 •
edited
Loading

Closes #17059

@ibetitsmike ibetitsmike changed the title remove speakeasy dependency; implement input recapture feat: enable masking password inputs instead of blocking echo Apr 18, 2025
deansheather
deansheather reviewed Apr 19, 2025
View reviewed changes
deansheather
deansheather previously approved these changes Apr 22, 2025
View reviewed changes
@deansheather deansheather dismissed their stale review April 22, 2025 13:37

didn't mean to approve my bad

deansheather
deansheather approved these changes Apr 24, 2025
View reviewed changes
@ibetitsmike ibetitsmike merged commit 9922240 into main Apr 24, 2025
34 checks passed
@ibetitsmike ibetitsmike deleted the mike/17059-hide-tokens-coder-cli branch April 24, 2025 07:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@ibetitsmike ibetitsmike

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show ******** when token is pasted in Coder CLI
2 participants
@ibetitsmike @deansheather