test: create unit test to match nil deref behavior #17501

Emyrk · 2025-04-22T13:54:42Z

Hit this panic in a deployment:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x322d541]

goroutine 50263 [running]:
github.com/coder/coder/v2/coderd.(*OIDCConfig).TokenSource(0x103e2078?, {0x13dd2590?, 0xc013de1e60?}, 0x28748d58?)
	<autogenerated>:1 +0x21
github.com/coder/coder/v2/coderd/provisionerdserver.obtainOIDCAccessToken({0x13dd2590, 0xc013de1e60}, {0x13e8e1f8, 0xc000f31950}, {0x13dc7fc0, 0x0}, {0x24, 0xec, 0x29, 0x28, ...})
	/home/steven/go/src/github.com/coder/coder/coderd/provisionerdserver/provisionerdserver.go:2355 +0x322
github.com/coder/coder/v2/coderd/provisionerdserver.(*server).acquireProtoJob(_, {_, _}, {{0x43, 0xa3, 0xff, 0x87, 0x50, 0x60, 0x4c, ...}, ...})
	/home/steven/go/src/github.com/coder/coder/coderd/provisionerdserver/provisionerdserver.go:519 +0x2191
github.com/coder/coder/v2/coderd/provisionerdserver.(*server).AcquireJobWithCancel(0xc000d3a1a0, {0x13de5e10, 0xc0036f40f0})
	/home/steven/go/src/github.com/coder/coder/coderd/provisionerdserver/provisionerdserver.go:398 +0xb7a
github.com/coder/coder/v2/provisionerd/proto.DRPCProvisionerDaemonDescription.Method.func2({0x4286da0?, 0xc000d3a1a0}, {0xc000c60380?, 0x16599c60?}, {0x430bc40?, 0xc001601b08}, {0x531a94?, 0x13dd2408?})
	/home/steven/go/src/github.com/coder/coder/provisionerd/proto/provisionerd_drpc.pb.go:197 +0x134
storj.io/drpc/drpcmux.(*Mux).HandleRPC(0xc000600008?, {0x13dde280, 0xc001601b08}, {0xc000c60380, 0x34})
	/home/steven/go/pkg/mod/storj.io/drpc@v0.0.33/drpcmux/handle_rpc.go:33 +0x207
github.com/coder/coder/v2/coderd/tracing.(*DRPCHandler).HandleRPC(0xc013bbf1c0, {0x13dde280, 0xc001601b08}, {0xc000c60380, 0x34})
	/home/steven/go/src/github.com/coder/coder/coderd/tracing/drpc.go:23 +0x1bb
storj.io/drpc/drpcserver.(*Server).handleRPC(0xc001b421c0?, 0xc001601b08, {0xc000c60380?, 0x16599c60?})
	/home/steven/go/pkg/mod/storj.io/drpc@v0.0.33/drpcserver/server.go:124 +0x36
storj.io/drpc/drpcserver.(*Server).ServeOne(0xc00072f500, {0x13dd6f58, 0xc013b62690}, {0x7465634314a8?, 0xc002065860?})
	/home/steven/go/pkg/mod/storj.io/drpc@v0.0.33/drpcserver/server.go:66 +0x1b3
storj.io/drpc/drpcserver.(*Server).Serve.func2({0x13dd6f58?, 0xc013b62690?})
	/home/steven/go/pkg/mod/storj.io/drpc@v0.0.33/drpcserver/server.go:114 +0x57
storj.io/drpc/drpcctx.(*Tracker).track(0xc013b62690, 0xc013bb76c0?)
	/home/steven/go/pkg/mod/storj.io/drpc@v0.0.33/drpcctx/tracker.go:35 +0x25
created by storj.io/drpc/drpcctx.(*Tracker).Run in goroutine 549
	/home/steven/go/pkg/mod/storj.io/drpc@v0.0.33/drpcctx/tracker.go:30 +0x76

Unfortunate solution

johnstcn

This is the correct solution if you only know the interface type and not the underlying concrete type.

ref: https://groups.google.com/g/golang-nuts/c/wnH302gBa4I

test: create unit test to match nil deref behavior

97a0183

github-actions bot assigned Emyrk Apr 22, 2025

Emyrk and others added 3 commits April 22, 2025 09:15

better test

7fcd5eb

chore: use reflect to determine nil

ba6c960

Unfortunate solution

Merge branch 'main' into stevenmasley/oidc_panic

b06339c

johnstcn approved these changes Apr 23, 2025

View reviewed changes

Emyrk merged commit 71dbd0c into main Apr 23, 2025
34 checks passed

Emyrk deleted the stevenmasley/oidc_panic branch April 23, 2025 13:45

github-actions bot locked and limited conversation to collaborators Apr 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: create unit test to match nil deref behavior #17501

test: create unit test to match nil deref behavior #17501

Emyrk commented Apr 22, 2025

johnstcn left a comment •

edited

Loading

test: create unit test to match nil deref behavior #17501

test: create unit test to match nil deref behavior #17501

Conversation

Emyrk commented Apr 22, 2025

johnstcn left a comment • edited Loading

Choose a reason for hiding this comment

johnstcn left a comment •

edited

Loading