Skip to content

test: create unit test to match nil deref behavior #17501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025
Merged

test: create unit test to match nil deref behavior #17501

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97a0183
test: create unit test to match nil deref behavior
Emyrk Apr 22, 2025
7fcd5eb
better test
Emyrk Apr 22, 2025
ba6c960
chore: use reflect to determine nil
Emyrk Apr 22, 2025
b06339c
Merge branch 'main' into stevenmasley/oidc_panic
Emyrk Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: use reflect to determine nil 
Unfortunate solution
  • Loading branch information
@Emyrk
Emyrk committed Apr 22, 2025
commit ba6c96083c8426d5c7cbc19b628817a01c7620fe
4 changes: 3 additions & 1 deletion coderd/provisionerdserver/provisionerdserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,9 @@ func (s *server) acquireProtoJob(ctx context.Context, job database.ProvisionerJo
}

var workspaceOwnerOIDCAccessToken string
if s.OIDCConfig != nil {
// The check `s.OIDCConfig != nil` is not as strict, since it can be an interface
// pointing to a typed nil.
if !reflect.ValueOf(s.OIDCConfig).IsNil() {
workspaceOwnerOIDCAccessToken, err = obtainOIDCAccessToken(ctx, s.Database, s.OIDCConfig, owner.ID)
if err != nil {
return nil, failJob(fmt.Sprintf("obtain OIDC access token: %s", err))
Expand Down
Loading