fix: handle extra workspace name case #17549
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect normalization of workspace names when using the "workspace.agent" format, addressing an issue discovered with JetBrains Toolbox.
- Added a new test case in cli/ssh_test.go to validate the "workspace.agent" input format.
- Modified the normalization logic in cli/ssh.go to correctly differentiate between "owner/workspace" and "workspace.agent" inputs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/ssh_test.go | Added a test case to cover workspace names in the "workspace.agent" format. |
| cli/ssh.go | Updated normalization logic to support the new workspace name format. |
Comments suppressed due to low confidence (2)
cli/ssh.go:1472
- [nitpick] Consider refactoring this condition to more explicitly differentiate between 'owner/workspace' and 'workspace.agent' formats. For instance, checking for a '.' could improve readability for inputs meant as 'workspace.agent'.
if strings.Contains(input, "/") || strings.Contains(input, "--") {
cli/ssh_test.go:109
- [nitpick] Consider adding additional test cases covering edge cases such as workspace names with multiple dots or unexpected characters to ensure comprehensive input normalization.
"myworkspace.dev",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced here: #17154
This fixes an issue that came up in jetbrains-toolbox development where we do not properly handle the
workspace.agentformat.