Skip to content

chore: resolve internal drpc package conflict #17770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 12, 2025

Our internal drpc package name conflicts with the external one in usage. It was confusing that drpc.* sometimes was our internal pkg, and sometimes not.

Copy link
Member Author

Emyrk commented May 12, 2025

@Emyrk Emyrk force-pushed the stevenmasley/larger_proto_limit branch from 61c2ff9 to 761c262 Compare May 12, 2025 14:48
@Emyrk Emyrk force-pushed the stevenmasley/larger_proto_limit branch from 761c262 to 98815ee Compare May 12, 2025 14:53
@Emyrk Emyrk changed the title chore: deconflict internal drpc package chore: resolve internal drpc package conflict May 12, 2025
@Emyrk Emyrk marked this pull request as ready for review May 12, 2025 15:20
@Emyrk Emyrk requested a review from johnstcn May 12, 2025 15:26
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like this.

@Emyrk Emyrk merged commit 3783241 into main May 12, 2025
41 checks passed
@Emyrk Emyrk deleted the stevenmasley/larger_proto_limit branch May 12, 2025 15:31
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants