feat: add one shot commands to the coder ssh command #17779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
approved these changes
May 15, 2025
Comment on lines
+98
to
+107
| func(next serpent.HandlerFunc) serpent.HandlerFunc { | ||
| return func(i *serpent.Invocation) error { | ||
| got := len(i.Args) | ||
| if got < 1 { | ||
| return xerrors.New("expected the name of a workspace") | ||
| } | ||
|
|
||
| return next(i) | ||
| } | ||
| }, |
There was a problem hiding this comment.
Keep this here, but we should add a serpent MW for RequireMinArgs(n). I also wanted it at some point.
cli/ssh.go
Outdated
| Use: "ssh <workspace>", | ||
| Short: "Start a shell into a workspace", | ||
| Use: "ssh <workspace> [command]", | ||
| Short: "Start a shell into a workspace or run a command", | ||
| Long: "This command does not have full parity with the standard SSH command. For users who need the full functionality of SSH, create an ssh configuration with `coder config-ssh`.", |
There was a problem hiding this comment.
ssh <workspace> ls -la works, but coder ssh <workspace> ls -la does not. I don't think we have to fix this, but we should have an example on how to pass flags. It is common unix stuff, but worth throwing in here imo.
Suggested change
| Long: "This command does not have full parity with the standard SSH command. For users who need the full functionality of SSH, create an ssh configuration with `coder config-ssh`.", | |
| Long: "This command does not have full parity with the standard SSH command. For users who need the full functionality of SSH, create an ssh configuration with `coder config-ssh`.\n" + | |
| FormatExamples( | |
| Example{ | |
| Description: "Use `--` to separate and pass flags directly to the command executed via SSH.", | |
| Command: "coder ssh <workspace> -- ls -la", | |
| }, | |
| ), |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2154
Warning
The tests in this PR were co-authored by AI