chore: add 'classic_parameter_flow' column setting to templates #17828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaulting to true
|
@Emyrk Do you mean we are removing the dynamic parameters experiment next week? |
aslilac
reviewed
May 14, 2025
We might be. I forgot it depends on the smoke test |
4ada164 to
a90c6a0
Compare
…_dyn_param_toggle
|
In terms of design I think we could:
Feel free to ignore them if you think they are out of this scope. 👍 |
BrunoQuaresma
approved these changes
May 15, 2025
I am going to leave this as our other checkboxes are like this. I reduced the description text, so it should look a bit better being smaller.
👍 |
jaaydenh
approved these changes
May 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are forcing users to try the dynamic parameter experience first. Currently this setting only comes into effect if an experiment is enabled, however we are removing that experiment very soon.
So I am just going to show the setting, rather than have to add logic I will remove before the next release.
What this does
The checkbox gives the template admin to opt a template out of the dynamic parameters experience, and use the existing form. We expect some bugs, so if a template has some issues, turning this off template wide prevents the end user from hitting any errors to begin with.
This does default to the new experience, as we want to force the template admins to try dynamic params first.
Regardless of this checkbox, the user can manually switch experiences at will.