Skip to content

refactor: use the new Table component for the Templates table #17838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

refactor: use the new Table component for the Templates table #17838

merged 1 commit into from
May 14, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

Screenshot 2025-05-14 at 15 11 56

@BrunoQuaresma BrunoQuaresma requested a review from a team May 14, 2025 18:13
@BrunoQuaresma BrunoQuaresma self-assigned this May 14, 2025
@BrunoQuaresma BrunoQuaresma requested review from brettkolodny and removed request for a team May 14, 2025 18:13
brettkolodny
brettkolodny approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@brettkolodny brettkolodny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but it seems like on the templates page the new table doesn't have the same horizontal scroll behavior. Is this intentional and if not is this something we care about?

New:
CleanShot 2025-05-14 at 14 32 03

Old:
CleanShot 2025-05-14 at 14 31 55

@BrunoQuaresma BrunoQuaresma merged commit 35a04c7 into main May 14, 2025
36 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/update-templates-tables branch May 14, 2025 20:11
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented May 15, 2025 •
edited
Loading

@brettkolodny yes, it is expected for this new table design, but we definitely need to do a better job with table for responsive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brettkolodny brettkolodny brettkolodny approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @brettkolodny