feat(agent/agentcontainers): update containers periodically #17972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84e7fb1 to
25ead7b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This change introduces a significant refactor to the agentcontainers API and enabled periodic updates of Docker containers rather than on-demand. Consequently this change also allows us to move away from using a locking channel and replace it with a mutex, which simplifies usage. Additionally a previous oversight was fixed, and testing added, to clear devcontainer running/dirty status when the container has been removed. Updates #16424 Updates coder/internal#621
johnstcn
reviewed
May 21, 2025
agent/agentcontainers/api.go
Outdated
Comment on lines
264
to
266
| defer func() { sema <- struct{}{} }() | ||
|
|
||
| return api.updateContainers(api.ctx) |
There was a problem hiding this comment.
Would it make sense instead to just return early from doUpdate() if we're not able to read from sema? Queueing multiple updates seems like it could cause increased memory usage over time, and I'm not sure what value we get from running it right again after one instance has just completed.
There was a problem hiding this comment.
If we did that, we can't wait for it to complete in the refreshContainers function. I'll see if there's any point in keeping a refresh method around after I refactor the recreate endpoint.
DanielleMaywood
approved these changes
May 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a significant refactor to the agentcontainers API
and enables periodic updates of Docker containers rather than on-demand.
Consequently this change also allows us to move away from using a
locking channel and replace it with a mutex, which simplifies usage.
Additionally a previous oversight was fixed, and testing added, to clear
devcontainer running/dirty status when the container has been removed.
Updates #16424
Updates coder/internal#621