Skip to content

chore: remove chartjs #18016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2025
Merged

chore: remove chartjs #18016

merged 4 commits into from
May 24, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Remove ChartJS in favor of Recharts
  • Migrate ActiveUserChart to use the new chart design
Screenshot 2025-05-23 at 15 00 03

@BrunoQuaresma BrunoQuaresma requested a review from a team May 23, 2025 18:11
@BrunoQuaresma BrunoQuaresma self-assigned this May 23, 2025
@BrunoQuaresma BrunoQuaresma requested review from aqandrew and removed request for a team May 23, 2025 18:11
Copy link

@aqandrew aqandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used Recharts before, but components that you can add classnames to (and insert SVG elements like gradient defs into) seem easier to work with than a big config object.

I like that the region that activates the tooltip is much bigger now, basically the entire chart instead of just each datapoint. Good stuff!

@BrunoQuaresma BrunoQuaresma merged commit 70edc24 into main May 24, 2025
33 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/replace-chartjs branch May 24, 2025 14:33
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants