Skip to content

chore: remove chartjs #18016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2025
Merged

chore: remove chartjs #18016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95a2259
chore: replace chartjs
BrunoQuaresma May 23, 2025
fc30abd
Fix one missing props
BrunoQuaresma May 23, 2025
e47779d
Fix FMT and Lint
BrunoQuaresma May 23, 2025
98020fa
Merge branch 'main' into bq/replace-chartjs
BrunoQuaresma May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix FMT and Lint
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 23, 2025
commit e47779d6e4219726ec14c3bfffeee086ea439f40
16 changes: 1 addition & 15 deletions site/src/components/ActiveUserChart/ActiveUserChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const meta: Meta<typeof ActiveUserChart> = {
{ date: "2024-01-06", amount: 10 },
{ date: "2024-01-07", amount: 11 },
],
interval: "day",
},
decorators: [
(Story) => (
Expand All @@ -30,19 +29,6 @@ type Story = StoryObj<typeof ActiveUserChart>;

export const Example: Story = {};

export const WeeklyExample: Story = {
args: {
interval: "week",
data: [
{ date: "2024-01-01", amount: 12 },
{ date: "2024-01-08", amount: 15 },
{ date: "2024-01-15", amount: 18 },
{ date: "2024-01-22", amount: 22 },
{ date: "2024-01-29", amount: 25 },
],
},
};

export const ManyDataPoints: Story = {
args: {
data: Array.from({ length: 30 }).map((_, i) => {
Expand All @@ -53,4 +39,4 @@ export const ManyDataPoints: Story = {
};
}),
},
};
};
16 changes: 8 additions & 8 deletions site/src/components/ActiveUserChart/ActiveUserChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
import type { FC } from "react";
import { XAxis, YAxis, CartesianGrid, AreaChart, Area } from "recharts";
import {
type ChartConfig,
ChartContainer,
ChartTooltip,
ChartTooltipContent,
} from "components/Chart/Chart";
import {
HelpTooltip,
HelpTooltipContent,
HelpTooltipText,
HelpTooltipTitle,
HelpTooltipTrigger,
} from "components/HelpTooltip/HelpTooltip";
import {
ChartContainer,
ChartTooltip,
ChartTooltipContent,
type ChartConfig,
} from "components/Chart/Chart";
import type { FC } from "react";
import { Area, AreaChart, CartesianGrid, XAxis, YAxis } from "recharts";

const chartConfig = {
amount: {
Expand Down