refactor: Generalize log ownership to allow for scratch jobs #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 67.82% 68.11% +0.28%
==========================================
Files 107 108 +1
Lines 5650 5632 -18
Branches 68 68
==========================================
+ Hits 3832 3836 +4
+ Misses 1461 1435 -26
- Partials 357 361 +4
Continue to review full report at Codecov.
|
d1a5fce to
024a391
Compare
Importing may fail when creating a project. We don't want to lose this output, but we don't want to allow users to create a failing project. This generalizes logs to soon enable one-off situations where a user can upload their archive, create a project, and watch the output parse to completion.
024a391 to
7afd3fb
Compare
bryphe-coder
reviewed
Feb 7, 2022
bryphe-coder
reviewed
Feb 7, 2022
bryphe-coder
reviewed
Feb 7, 2022
bryphe-coder
reviewed
Feb 7, 2022
Comment on lines
+247
to
+248
| // This will be replaced once the project import has been refactored. | ||
| ProjectName: "placeholder", |
There was a problem hiding this comment.
Thanks for explaining this 😄
bryphe-coder
approved these changes
Feb 7, 2022
55677fc to
714e962
Compare
41cd419 to
b168e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing may fail when creating a project. We don't want to lose this output,
but we don't want to allow users to create a failing project.
This generalizes logs to soon enable one-off situations where a user can upload
their archive, create a project, and watch the output parse to completion.