Skip to content

refactor: Generalize log ownership to allow for scratch jobs #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2022
Merged

refactor: Generalize log ownership to allow for scratch jobs #182

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7afd3fb
refactor: Generalize log ownership to allow for scratch jobs
kylecarbs Feb 7, 2022
6e6beb4
Improve file table schema by using hash
kylecarbs Feb 7, 2022
b168e3d
Fix racey test by allowing logs before
kylecarbs Feb 7, 2022
4bced84
Merge branch 'main' into generalizelogs
kylecarbs Feb 7, 2022
a706956
Add debug logging for PostgreSQL insert
kylecarbs Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add debug logging for PostgreSQL insert
  • Loading branch information
@kylecarbs
kylecarbs committed Feb 7, 2022
commit a70695680cc0ae0479c3dcbfc88e16ab1fc13299
1 change: 1 addition & 0 deletions coderd/provisionerdaemons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ func (server *provisionerdServer) UpdateJob(stream proto.DRPCProvisionerDaemon_U
}
logs, err := server.Database.InsertProvisionerJobLogs(stream.Context(), insertParams)
if err != nil {
server.Logger.Error(stream.Context(), "insert provisioner job logs", slog.Error(err))
return xerrors.Errorf("insert job logs: %w", err)
}
data, err := json.Marshal(logs)
Expand Down