Skip to content

feat: port forwarding dropdown #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

feat: port forwarding dropdown #1824

wants to merge 5 commits into from

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented May 27, 2022

What this does:

  • Adds a web socket to the agent that scans for listening ports on an interval
  • Displays those ports in a popup when you open said popup
  • The popup also lets you manually open ports in case the detection is not working

Todo:

  • Fails on darwin, I think because the netstat package does not support darwin. Not sure how to fix this yet.
  • Add comprehensive frontend test similar to the terminal test (only the individual parts are tested right now).
  • Probably need to filter out some ports like 22.
  • Not sure if the proxy backend is built out yet so the ports link to a temporary non-working URL right now.

Closes #1624

lame-demo-0006-2022-05-27_12.14.16.mp4

@code-asher code-asher force-pushed the asher/ports branch 3 times, most recently from a911ed7 to 63da850 Compare May 27, 2022 21:03
@ammario
Copy link
Member

ammario commented Jun 15, 2022

What's the status of this feature?

@code-asher
Copy link
Member Author

This is blocked on being able to actually open a link to a port. I messed up because I thought work on that was underway but it seems actually not to be? I was thinking I could just add it myself but I have not found the time to work on that yet.

IDK how we plan on doing the sub-domain version but since we already have /apps I imagine it would not be too much work to add a path-based version with a port number in it, something like /proxy/{port-number}.

@ammario
Copy link
Member

ammario commented Jun 16, 2022

This is blocked on being able to actually open a link to a port. I messed up because I thought work on that was underway but it seems actually not to be? I was thinking I could just add it myself but I have not found the time to work on that yet.

I have no clue where the other work sits. Perhaps @tjcran can shed some light here. It's unfortunate to watch the ever-increasing merge conflicts erode this code. Dev URLs are a necessary feature for about half of our v1 users that are browser only.

IDK how we plan on doing the sub-domain version but since we already have /apps I imagine it would not be too much work to add a path-based version with a port number in it, something like /proxy/{port-number}.

Yeah, the wildcard subdomain setup always sucks. I think we all know the limitations of the path-based solution, but it could be an interesting fallback when the wildcard domain isn't setup yet. If we did that, we would want to make it very clear_ to the user that they could setup a path-less solution.

@tjcran
Copy link

tjcran commented Jun 16, 2022

@ammario i believe @kylecarbs is doing the work for that. I'll let him comment.

@kylecarbs
Copy link
Member

That work is partially implemented by the #1773 PR. The wildcard subdomain routing and authentication still needs to be added. It's a bit of an awkward UX for our current setup experience, so I think we should align on how we'll do that before continuing. We can replicate the v1 experience, but it wasn't very smooth.

@kylecarbs
Copy link
Member

To clarify, this is fully blocked on me, not @code-asher!

@kylecarbs
Copy link
Member

This should stay open until we make headway on #2986. It'll certainly come into play!

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jul 29, 2022
@github-actions github-actions bot closed this Aug 1, 2022
@github-actions github-actions bot deleted the asher/ports branch February 4, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue is like stale bread.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to open any port in dashboard
4 participants