Skip to content

fix(enterprise/coderd): skip org membership check for prebuilds user on group patch #18329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

fix(enterprise/coderd): skip org membership check for prebuilds user on group patch #18329

merged 3 commits into from
Jun 23, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 11, 2025 •
edited by dannykopping
Loading

Currently, the prebuilds documentation states:

### Managing resource quotas

Prebuilt workspaces can be used in conjunction with [resource quotas](../../users/quotas.md).
Because unclaimed prebuilt workspaces are owned by the `prebuilds` user, you can:

1. Configure quotas for any group that includes this user.
1. Set appropriate limits to balance prebuilt workspace availability with resource constraints.

If a quota is exceeded, the prebuilt workspace will fail provisioning the same way other workspaces do.

If you need to have a separate quota for prebuilds as opposed to regular users, you are required to create a separate group, as quotas are applied to groups.

Currently it is not possible to create a separate 'prebuilds' group with only the prebuilds user to add a quota. This PR skips the org membership check specifically for the prebuilds user when patching a group.

image

@johnstcn johnstcn self-assigned this Jun 11, 2025
dannykopping
dannykopping approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love your bias-to-action, my man ❤️

@github-actions github-actions bot added the stale This issue is like stale bread. label Jun 19, 2025
@github-actions github-actions bot closed this Jun 22, 2025
@dannykopping dannykopping reopened this Jun 23, 2025
@johnstcn johnstcn force-pushed the cj/patch-group-skip-prebuilds-user branch from b7fff24 to d48e08e Compare June 23, 2025 08:19
@johnstcn johnstcn mentioned this pull request Jun 23, 2025
Open
@johnstcn johnstcn merged commit 0a12ec5 into main Jun 23, 2025
34 checks passed
@johnstcn johnstcn deleted the cj/patch-group-skip-prebuilds-user branch June 23, 2025 09:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@SasSwart SasSwart Awaiting requested review from SasSwart

Assignees

@johnstcn johnstcn

Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @dannykopping