feat: add backend logic for determining tasks tab visibility #18401
+145
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
approved these changes
Jun 18, 2025
|
|
||
| hasAITask, err := h.opts.Database.HasTemplateVersionsWithAITask(ctx) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
An error here will cause all the other goroutines to be canceled; should we rather log only since this isn't an essential feature?
| go func() { | ||
| defer wg.Done() | ||
| tasksTabVisible, err := json.Marshal(tasksTabVisible) | ||
| if err == nil { |
There was a problem hiding this comment.
Let's rather log on error and explicitly set TasksTabVisible to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the backend logic for determining if the Tasks tab should be visible in the web UI as described in the RFC.
The frontend component will be added in a follow-up PR once the entire Tasks backend is implemented so as not to break the dogfood environment until then.