Skip to content

test(testutil): improve chan.go error visibility #18406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jun 17, 2025

This has bit me multiple times as the error is basically invisible. Changed to assert/require which make it more obvious:

Before:

image

After:

image

@mafredri mafredri force-pushed the mafredri/fix-testutil-errors branch from bb1b979 to e9d3386 Compare June 17, 2025 14:26
@mafredri mafredri enabled auto-merge (squash) June 17, 2025 14:31
@mafredri mafredri merged commit b9ac16c into main Jun 17, 2025
34 checks passed
@mafredri mafredri deleted the mafredri/fix-testutil-errors branch June 17, 2025 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants