feat(dogfood/coder): add docker volume for... docker #18455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is in preparation for enabling devcontainers as well as allowing Docker image cache to be re-used across workspace restarts. For now, any running container will result in the retention of related resources (image, volumes, etc).
DanielleMaywood
approved these changes
Jun 19, 2025
The current plan relies on the user not starting a container, and shutting down their workspace which will always clear everything. Likewise, if updated images are pulled, the old parts of that image will be pruned away on shutdown. |
johnstcn
approved these changes
Jun 19, 2025
|
If this becomes a problem, we can simply force deletion of all containers again. |
SGTM 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in preparation for enabling devcontainers as well as
allowing Docker image cache to be re-used across workspace restarts.
For now, any running container will result in the retention of related
resources (image, volumes, etc).
Updates coder/internal#463