chore: populate connectionlog count using a separate query #18629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed8e139 to
8cec6d1
Compare
a031154 to
d03fe73
Compare
8cec6d1 to
482a5d3
Compare
d03fe73 to
8cbd44a
Compare
482a5d3 to
ccc7539
Compare
8cbd44a to
09cbe49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
deansheather
approved these changes
Jul 2, 2025
ccc7539 to
406e3f4
Compare
713ca71 to
33d8acb
Compare
33d8acb to
1e3334b
Compare
88bf416 to
cd30512
Compare
1e3334b to
332f8da
Compare
cd30512 to
3a8822d
Compare
332f8da to
6cd9d68
Compare
This was referenced Jul 7, 2025
3a8822d to
02a93e0
Compare
6cd9d68 to
6fa4d22
Compare
02a93e0 to
2231707
Compare
769b7a5 to
fc195c3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for returning the total count of connection logs alongside paginated results by issuing a separate COUNT query.
- API handler is updated to fetch and return
CountinConnectionLogResponse, with early exit on zero count. searchquery.ConnectionLogsnow returns a count filter, and corresponding tests are updated.- New SQL query, querier methods, authz, metrics, and tests are added to support
CountConnectionLogs.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| enterprise/coderd/connectionlog.go | Call CountConnectionLogs, early exit on zero, include count. |
| enterprise/coderd/connectionlog_test.go | Updated tests to assert logs.Count for various scenarios. |
| coderd/searchquery/search.go & coderd/searchquery/search_test.go | ConnectionLogs now returns countFilter; tests updated. |
| coderd/database/queries/connectionlogs.sql & queries.sql.go | Added CountConnectionLogs SQL and generated Go code. |
| coderd/database/querier.go & coderd/database/querier_test.go | Added CountConnectionLogs and CountAuthorizedConnectionLogs with tests. |
| coderd/database/dbmock/dbmock.go | Mock methods for CountConnectionLogs and CountAuthorizedConnectionLogs. |
| coderd/database/dbmetrics/querymetrics.go | Metrics wrappers for the new count methods. |
| coderd/database/dbauthz/*.go & setup_test.go & dbauthz_test.go | Authorization logic and tests for counting connection logs. |
Comments suppressed due to low confidence (1)
coderd/searchquery/search_test.go:430
- [nitpick] The variable name
valuesis ambiguous in this context. Consider renaming it to something likefilterParamsoroffsetParamsto clarify it holds the parameters for the offset query.
})
2231707 to
133e51d
Compare
fc195c3 to
df2d839
Compare
133e51d to
b8faf73
Compare
df2d839 to
78cc56b
Compare
b8faf73 to
3ec1f06
Compare
78cc56b to
e61fc41
Compare
3ec1f06 to
c013e9f
Compare
e61fc41 to
4055dd7
Compare
Merge activity
|
4055dd7 to
e10a5cf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third PR for moving connection events out of the audit log.
This PR populates
countonConnectionLogResponseusing a separate query, to preemptively mitigate the issue described in #17689. It's structurally identical to a portion of #18600, but for the connection log instead of the audit log.Future PRs: