Skip to content

chore: mark workspace apps and workspace agents as unaudited #18761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

chore: mark workspace apps and workspace agents as unaudited #18761

merged 1 commit into from
Jul 15, 2025
+116 −85

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jul 7, 2025 •
edited
Loading

The main goal of this PR is to remove Workspace Apps and Workspace Agents from the auto-generated audit log documentation, that incorrectly claims they are audited resources (no longer true with the addition of the connection log).

Though I believe we haven't touched any codepaths for returning audit logs, this PR also adds a test that ensures we continue to return existing connection, disconnect and open events correctly from the audit log API.

This was referenced Jul 7, 2025
Merged
Merged
Merged
Merged
Merged
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Jul 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson mentioned this pull request Jul 7, 2025
Merged
@ethanndickson ethanndickson changed the title chore(coderd/audit): remove workspace app and agent from Auditable chore: mark workspace apps and workspace audits as unaudited Jul 7, 2025
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 4802e88 to bd16b9d Compare July 7, 2025 07:34
@ethanndickson ethanndickson marked this pull request as ready for review July 7, 2025 07:35
@ethanndickson ethanndickson changed the title chore: mark workspace apps and workspace audits as unaudited chore: mark workspace apps and workspace agents as unaudited Jul 7, 2025
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from c5131a3 to d14aa91 Compare July 7, 2025 09:34
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from bd16b9d to 273363f Compare July 7, 2025 09:34
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from d14aa91 to a4bb7c4 Compare July 8, 2025 08:58
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch 2 times, most recently from 7c35e80 to 8e0a43d Compare July 9, 2025 05:58
@ethanndickson ethanndickson mentioned this pull request Jul 9, 2025
Merged
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from 451bfd9 to 59a7992 Compare July 10, 2025 05:58
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 8e0a43d to 3b8277b Compare July 10, 2025 05:58
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from 59a7992 to 13569cb Compare July 10, 2025 10:29
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 3b8277b to 93a9073 Compare July 10, 2025 10:29
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from 13569cb to ad9a966 Compare July 10, 2025 10:37
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 93a9073 to 23079d7 Compare July 10, 2025 10:37
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from ad9a966 to 5153f7b Compare July 10, 2025 10:50
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 23079d7 to 27eea0a Compare July 10, 2025 10:50
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from 5153f7b to 6c2f035 Compare July 14, 2025 02:04
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 27eea0a to 8a35e5f Compare July 14, 2025 02:05
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from 6c2f035 to fab8dbd Compare July 14, 2025 06:13
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 8a35e5f to c58bc89 Compare July 14, 2025 06:13
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from fab8dbd to 245c72d Compare July 15, 2025 03:33
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from c58bc89 to 72a0299 Compare July 15, 2025 03:33
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from 245c72d to 111ff29 Compare July 15, 2025 04:00
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 72a0299 to 44097ed Compare July 15, 2025 04:00
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch from 111ff29 to 6eb7cbe Compare July 15, 2025 05:12
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 44097ed to 85c01aa Compare July 15, 2025 05:13
@ethanndickson ethanndickson force-pushed the ethan/docs-add-connection-logs branch 2 times, most recently from 327e549 to e8b4e70 Compare July 15, 2025 05:46
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 85c01aa to 425c2dc Compare July 15, 2025 05:46
@ethanndickson ethanndickson changed the base branch from ethan/docs-add-connection-logs to graphite-base/18761 July 15, 2025 05:52
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 425c2dc to 29e78d1 Compare July 15, 2025 05:52
@graphite-app graphite-app bot changed the base branch from graphite-base/18761 to main July 15, 2025 05:53
@ethanndickson ethanndickson force-pushed the ethan/remove-workspace-app-agent-auditable branch from 29e78d1 to 0d73833 Compare July 15, 2025 05:53
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Jul 15, 2025 •
edited
Loading

Merge activity

  • Jul 15, 6:08 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 15, 6:08 AM UTC: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit ef807e4 into main Jul 15, 2025
33 checks passed
@ethanndickson ethanndickson deleted the ethan/remove-workspace-app-agent-auditable branch July 15, 2025 06:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @deansheather