Skip to content

fix(site): update vs code dev container button URLs #18696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(site): update vs code dev container button URLs #18696

wants to merge 1 commit into from
+23 −3

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jul 1, 2025 •
edited
Loading

This updates the Dev Container VS Code button to include localWorkspaceFolder and localConfigFile that will be added in coder/vscode-coder#544.

This change is backwards compatible as the new arguments will be ignored.

Refs coder/vscode-coder#544
Refs #16426

@mafredri mafredri force-pushed the mafredri/fix-open-vscode-devcontainers-properly branch from a09db50 to 5885da1 Compare July 1, 2025 16:41
@mafredri mafredri marked this pull request as ready for review July 2, 2025 09:52
@Parkreiner
Copy link
Member

Parkreiner commented Jul 2, 2025 •
edited
Loading

Going to submit a review in must a minute. I have an idea for a piece of feedback, but I need to dig through a few files first to make sure it makes sense

Parkreiner
Parkreiner approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay (got caught up with Registry issues), but yeah, I'm okay with these changes

I'm a little concerned about the how the data is getting passed along (both button types receive a bunch of data dependencies, only for both to serialize them as almost identical strings). I'm worried someone might forget to update both (especially since URLSearchParams doesn't have a ton of type-safety), but my attempts at refactoring didn't really seem to make things that much better

I think I'd rather wait until we have more data to serialize before worrying about drift. Everything's contained in the same file right now, and the variants aren't exported, so this all seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @Parkreiner @DanielleMaywood