Skip to content

fix: set prebuilds lifecycle parameters on creation and claim #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
+485 −303
Open

fix: set prebuilds lifecycle parameters on creation and claim #19252

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6415069
fix: prebuilds lifecycle parameters on creation and claim
ssncferreira Aug 8, 2025
e322671
refactor: remove CLI schedule changes
ssncferreira Aug 8, 2025
85d24ab
refactor: remove activity bump changes
ssncferreira Aug 8, 2025
04a481d
refactor: remove lifecycle API endpoint changes
ssncferreira Aug 8, 2025
2761b7e
refactor: remove template lifecycle update changes
ssncferreira Aug 8, 2025
4c847c9
fix: add database constraints to prevent invalid lifecycle fields on …
ssncferreira Aug 8, 2025
2bc1070
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…
ssncferreira Aug 8, 2025
c42ef24
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…
ssncferreira Aug 11, 2025
8653a33
refactor: add lifecycle fields to prebuild claim database query
ssncferreira Aug 11, 2025
8486f3f
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…
ssncferreira Aug 11, 2025
b2c130f
fix: lifecycle executor prebuilds test
ssncferreira Aug 11, 2025
e54ba2a
refactor: use testutil.RequireReceive for receiving workspace lifecyc…
ssncferreira Aug 11, 2025
5781268
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…
ssncferreira Aug 12, 2025
837b02a
refactor: use api clock mock when creating workspace
ssncferreira Aug 12, 2025
23e753b
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…
ssncferreira Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove lifecycle API endpoint changes
  • Loading branch information
@ssncferreira
ssncferreira committed Aug 8, 2025
commit 04a481dde2d24d9772b2d546e3865431d2ed514e
43 changes: 0 additions & 43 deletions coderd/workspaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,17 +1090,6 @@ func (api *API) putWorkspaceAutostart(rw http.ResponseWriter, r *http.Request) {
return
}

// Autostart configuration is not supported for prebuilt workspaces.
// Prebuild lifecycle is managed by the reconciliation loop, with scheduling behavior
// defined per preset at the template level, not per workspace.
if workspace.IsPrebuild() {
httpapi.Write(ctx, rw, http.StatusUnprocessableEntity, codersdk.Response{
Message: "Autostart is not supported for prebuilt workspaces",
Detail: "Prebuilt workspace scheduling is configured per preset at the template level. Workspace-level overrides are not supported.",
})
return
}

dbSched, err := validWorkspaceSchedule(req.Schedule)
if err != nil {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Expand Down Expand Up @@ -1185,17 +1174,6 @@ func (api *API) putWorkspaceTTL(rw http.ResponseWriter, r *http.Request) {
return
}

// TTL updates are not supported for prebuilt workspaces.
// Prebuild lifecycle is managed by the reconciliation loop, with TTL behavior
// defined per preset at the template level, not per workspace.
if workspace.IsPrebuild() {
httpapi.Write(ctx, rw, http.StatusUnprocessableEntity, codersdk.Response{
Message: "TTL updates are not supported for prebuilt workspaces",
Detail: "Prebuilt workspace TTL is configured per preset at the template level. Workspace-level overrides are not supported.",
})
return
}

var dbTTL sql.NullInt64

err := api.Database.InTx(func(s database.Store) error {
Expand Down Expand Up @@ -1312,16 +1290,6 @@ func (api *API) putWorkspaceDormant(rw http.ResponseWriter, r *http.Request) {
return
}

// Dormancy configuration is not supported for prebuilt workspaces.
// Prebuilds are managed by the reconciliation loop and are not subject to dormancy.
if oldWorkspace.IsPrebuild() {
httpapi.Write(ctx, rw, http.StatusUnprocessableEntity, codersdk.Response{
Message: "Dormancy configuration is not supported for prebuilt workspaces",
Detail: "Prebuilt workspaces are not subject to dormancy. Dormancy behavior is only applicable to regular workspaces",
})
return
}

// If the workspace is already in the desired state do nothing!
if oldWorkspace.DormantAt.Valid == req.Dormant {
rw.WriteHeader(http.StatusNotModified)
Expand Down Expand Up @@ -1466,17 +1434,6 @@ func (api *API) putExtendWorkspace(rw http.ResponseWriter, r *http.Request) {
return
}

// Deadline extensions are not supported for prebuilt workspaces.
// Prebuilds are managed by the reconciliation loop and must always have
// Deadline and MaxDeadline unset.
if workspace.IsPrebuild() {
httpapi.Write(ctx, rw, http.StatusUnprocessableEntity, codersdk.Response{
Message: "Deadline extension is not supported for prebuilt workspaces",
Detail: "Prebuilt workspaces do not support user deadline modifications. Deadline extension is only applicable to regular workspaces",
})
return
}

code := http.StatusOK
resp := codersdk.Response{}

Expand Down
Loading