fix: prebuilds lifecycle parameters on creation and claim

coder · ssncferreira · Aug 8, 2025 · Aug 8, 2025 · Aug 8, 2025 · Aug 8, 2025
commit 641506981d323f034c12aa6aa98cd2bc51e0aaf7
diff --git a/cli/schedule.go b/cli/schedule.go
@@ -157,6 +157,13 @@ func (r *RootCmd) scheduleStart() *serpent.Command {
 				return err
 			}
 
+			// Autostart configuration is not supported for prebuilt workspaces.
+			// Prebuild lifecycle is managed by the reconciliation loop, with scheduling behavior
+			// defined per preset at the template level, not per workspace.
+			if workspace.IsPrebuild {
+				return xerrors.Errorf("autostart configuration is not supported for prebuilt workspaces")
+			}
+
 			var schedStr *string
 			if inv.Args[1] != "manual" {
 				sched, err := parseCLISchedule(inv.Args[1:]...)
@@ -205,6 +212,13 @@ func (r *RootCmd) scheduleStop() *serpent.Command {
 				return err
 			}
 
+			// Autostop configuration is not supported for prebuilt workspaces.
+			// Prebuild lifecycle is managed by the reconciliation loop, with scheduling behavior
+			// defined per preset at the template level, not per workspace.
+			if workspace.IsPrebuild {
+				return xerrors.Errorf("autostop configuration is not supported for prebuilt workspaces")
+			}
+
 			var durMillis *int64
 			if inv.Args[1] != "manual" {
 				dur, err := parseDuration(inv.Args[1])

diff --git a/coderd/database/querier.go b/coderd/database/querier.go
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/activitybump.sql b/coderd/database/queries/activitybump.sql
@@ -5,6 +5,8 @@
 --
 -- Max deadline is respected, and the deadline will never be bumped past it.
 -- The deadline will never decrease.
+-- NOTE: This query should only be called for regular user workspaces.
+-- Prebuilds are managed by the reconciliation loop and not subject to activity bumping.
 -- name: ActivityBumpWorkspace :exec
 WITH latest AS (
 	SELECT

diff --git a/coderd/database/queries/prebuilds.sql b/coderd/database/queries/prebuilds.sql
@@ -2,7 +2,15 @@
 UPDATE workspaces w
 SET owner_id   = @new_user_id::uuid,
 	name       = @new_name::text,
-	updated_at = NOW()
+	updated_at = NOW(),
+	-- Update last_used_at during claim to ensure the claimed workspace is treated as recently used.
+	-- This avoids unintended dormancy caused by prebuilds having stale usage timestamps.
+	last_used_at = NOW(),
+	-- Clear dormant and deletion timestamps as a safeguard to ensure a clean lifecycle state after claim.
+	-- These fields should not be set on prebuilds, but we defensively reset them here to prevent
+	-- accidental dormancy or deletion by the lifecycle executor.
+	dormant_at = NULL,
+	deleting_at = NULL
 WHERE w.id IN (
 	SELECT p.id
 	FROM workspace_prebuilds p

diff --git a/coderd/database/queries/workspacebuilds.sql b/coderd/database/queries/workspacebuilds.sql
@@ -135,6 +135,9 @@ WHERE
 	id = $1;
 
 -- name: UpdateWorkspaceBuildDeadlineByID :exec
+-- NOTE: This query should only be called for regular user workspaces.
+-- Prebuilds are managed by the reconciliation loop, not the lifecycle
+-- executor which handles deadline and max_deadline.
 UPDATE
 	workspace_builds
 SET

diff --git a/coderd/database/queries/workspaces.sql b/coderd/database/queries/workspaces.sql
@@ -512,6 +512,9 @@ WHERE
 RETURNING *;
 
 -- name: UpdateWorkspaceAutostart :exec
+-- NOTE: This query should only be called for regular user workspaces.
+-- Prebuilds are managed by the reconciliation loop, not the lifecycle
+-- executor which handles autostart_schedule and next_start_at.
 UPDATE
 	workspaces
 SET
@@ -521,6 +524,9 @@ WHERE
 	id = $1;
 
 -- name: UpdateWorkspaceNextStartAt :exec
+-- NOTE: This query should only be called for regular user workspaces.
+-- Prebuilds are managed by the reconciliation loop, not the lifecycle
+-- executor which handles next_start_at.
 UPDATE
 	workspaces
 SET
@@ -545,6 +551,9 @@ WHERE
 	workspaces.id = batch.id;
 
 -- name: UpdateWorkspaceTTL :exec
+-- NOTE: This query should only be called for regular user workspaces.
+-- Prebuilds are managed by the reconciliation loop, not the lifecycle
+-- executor which handles regular workspace's TTL.
 UPDATE
 	workspaces
 SET
@@ -554,11 +563,15 @@ WHERE
 
 -- name: UpdateWorkspacesTTLByTemplateID :exec
 UPDATE
-		workspaces
+	workspaces
 SET
-		ttl = $2
+	ttl = $2
 WHERE
-		template_id = $1;
+	template_id = $1
+	-- Prebuilt workspaces (identified by having the prebuilds system user as owner_id)
+	-- should not have their TTL updated, as they are handled by the prebuilds
+	-- reconciliation loop.
+	AND workspaces.owner_id != 'c42fdf75-3097-471c-8c33-fb52454d81c0'::UUID;
 
 -- name: UpdateWorkspaceLastUsedAt :exec
 UPDATE
@@ -768,6 +781,9 @@ WHERE
   	AND workspaces.owner_id != 'c42fdf75-3097-471c-8c33-fb52454d81c0'::UUID;
 
 -- name: UpdateWorkspaceDormantDeletingAt :one
+-- NOTE: This query should only be called for regular user workspaces.
+-- Prebuilds are managed by the reconciliation loop, not the lifecycle
+-- executor which handles dormant_at and deleting_at.
 UPDATE
     workspaces
 SET
@@ -805,8 +821,11 @@ SET
     dormant_at = CASE WHEN @dormant_at::timestamptz > '0001-01-01 00:00:00+00'::timestamptz THEN @dormant_at::timestamptz ELSE dormant_at END
 WHERE
     template_id = @template_id
-AND
-    dormant_at IS NOT NULL
+	AND dormant_at IS NOT NULL
+	-- Prebuilt workspaces (identified by having the prebuilds system user as owner_id)
+	-- should not have their dormant or deleting at set, as these are handled by the
+    -- prebuilds reconciliation loop.
+	AND workspaces.owner_id != 'c42fdf75-3097-471c-8c33-fb52454d81c0'::UUID
 RETURNING *;
 
 -- name: UpdateTemplateWorkspacesLastUsedAt :exec

diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -1183,11 +1183,18 @@ func (s *server) FailJob(ctx context.Context, failJob *proto.FailedJob) (*proto.
 				if err != nil {
 					return xerrors.Errorf("update workspace build state: %w", err)
 				}
+
+				deadline := build.Deadline
+				maxDeadline := build.MaxDeadline
+				if workspace.IsPrebuild() {
+					deadline = time.Time{}
+					maxDeadline = time.Time{}
+				}
 				err = db.UpdateWorkspaceBuildDeadlineByID(ctx, database.UpdateWorkspaceBuildDeadlineByIDParams{
 					ID:          input.WorkspaceBuildID,
 					UpdatedAt:   s.timeNow(),
-					Deadline:    build.Deadline,
-					MaxDeadline: build.MaxDeadline,
+					Deadline:    deadline,
+					MaxDeadline: maxDeadline,
 				})
 				if err != nil {
 					return xerrors.Errorf("update workspace build deadline: %w", err)
@@ -1860,38 +1867,47 @@ func (s *server) completeWorkspaceBuildJob(ctx context.Context, job database.Pro
 			return getWorkspaceError
 		}
 
-		templateScheduleStore := *s.TemplateScheduleStore.Load()
+		// Prebuilt workspaces must not have Deadline or MaxDeadline set,
+		// as they are managed by the prebuild reconciliation loop, not the lifecycle executor
+		deadline := time.Time{}
+		maxDeadline := time.Time{}
 
-		autoStop, err := schedule.CalculateAutostop(ctx, schedule.CalculateAutostopParams{
-			Database:                    db,
-			TemplateScheduleStore:       templateScheduleStore,
-			UserQuietHoursScheduleStore: *s.UserQuietHoursScheduleStore.Load(),
-			// `now` is used below to set the build completion time.
-			WorkspaceBuildCompletedAt: now,
-			Workspace:                 workspace.WorkspaceTable(),
-			// Allowed to be the empty string.
-			WorkspaceAutostart: workspace.AutostartSchedule.String,
-		})
-		if err != nil {
-			return xerrors.Errorf("calculate auto stop: %w", err)
-		}
+		if !workspace.IsPrebuild() {
+			templateScheduleStore := *s.TemplateScheduleStore.Load()
 
-		if workspace.AutostartSchedule.Valid {
-			templateScheduleOptions, err := templateScheduleStore.Get(ctx, db, workspace.TemplateID)
+			autoStop, err := schedule.CalculateAutostop(ctx, schedule.CalculateAutostopParams{
+				Database:                    db,
+				TemplateScheduleStore:       templateScheduleStore,
+				UserQuietHoursScheduleStore: *s.UserQuietHoursScheduleStore.Load(),
+				// `now` is used below to set the build completion time.
+				WorkspaceBuildCompletedAt: now,
+				Workspace:                 workspace.WorkspaceTable(),
+				// Allowed to be the empty string.
+				WorkspaceAutostart: workspace.AutostartSchedule.String,
+			})
 			if err != nil {
-				return xerrors.Errorf("get template schedule options: %w", err)
+				return xerrors.Errorf("calculate auto stop: %w", err)
 			}
 
-			nextStartAt, err := schedule.NextAllowedAutostart(now, workspace.AutostartSchedule.String, templateScheduleOptions)
-			if err == nil {
-				err = db.UpdateWorkspaceNextStartAt(ctx, database.UpdateWorkspaceNextStartAtParams{
-					ID:          workspace.ID,
-					NextStartAt: sql.NullTime{Valid: true, Time: nextStartAt.UTC()},
-				})
+			if workspace.AutostartSchedule.Valid {
+				templateScheduleOptions, err := templateScheduleStore.Get(ctx, db, workspace.TemplateID)
 				if err != nil {
-					return xerrors.Errorf("update workspace next start at: %w", err)
+					return xerrors.Errorf("get template schedule options: %w", err)
+				}
+
+				nextStartAt, err := schedule.NextAllowedAutostart(now, workspace.AutostartSchedule.String, templateScheduleOptions)
+				if err == nil {
+					err = db.UpdateWorkspaceNextStartAt(ctx, database.UpdateWorkspaceNextStartAtParams{
+						ID:          workspace.ID,
+						NextStartAt: sql.NullTime{Valid: true, Time: nextStartAt.UTC()},
+					})
+					if err != nil {
+						return xerrors.Errorf("update workspace next start at: %w", err)
+					}
 				}
 			}
+			deadline = autoStop.Deadline
+			maxDeadline = autoStop.MaxDeadline
 		}
 
 		err = db.UpdateProvisionerJobWithCompleteByID(ctx, database.UpdateProvisionerJobWithCompleteByIDParams{
@@ -1917,8 +1933,8 @@ func (s *server) completeWorkspaceBuildJob(ctx context.Context, job database.Pro
 		}
 		err = db.UpdateWorkspaceBuildDeadlineByID(ctx, database.UpdateWorkspaceBuildDeadlineByIDParams{
 			ID:          workspaceBuild.ID,
-			Deadline:    autoStop.Deadline,
-			MaxDeadline: autoStop.MaxDeadline,
+			Deadline:    deadline,
+			MaxDeadline: maxDeadline,
 			UpdatedAt:   now,
 		})
 		if err != nil {