fix: correct markup for Abbr component #19317
Merged
+50
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Aug 13, 2025
| pronunciation: Pronunciation; | ||
| }; | ||
|
|
||
| function assertAccessibleLabel({ |
There was a problem hiding this comment.
Got rid of the test helper because it felt like we were binding all our tests to a shallow abstraction
aslilac
approved these changes
Aug 13, 2025
| children === children.toUpperCase() | ||
| ? "tracking-wide" | ||
| : "tracking-normal", | ||
| "no-underline tracking-normal", |
There was a problem hiding this comment.
I wish we understood where the underline is coming from. these kinds of conflicts are so annoying. can we at least add a TODO to clean this up one day?
There was a problem hiding this comment.
So, the funny thing is, abbr elements have an underline by default in normal HTML – it's MUI that somehow overrode it
I actually don't think we should do anything – once MUI is out, we should be much closer to "normal" CSS, and this behavior would be 100% expected
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some accidental styling issues introduced in #19242
Changes made
classNameprop so that we can override the styles as neededNotes