Skip to content

refactor: generate task name fallback on coderd #19447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 21, 2025
+47 −21
Merged

refactor: generate task name fallback on coderd #19447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cf1815
refactor: generate task name fallback on coderd
DanielleMaywood Aug 20, 2025
620a01b
refactor: make `generateSuffix` internal
DanielleMaywood Aug 20, 2025
a9ccd72
fix: ensure `GenerateFallback` cannot be an invalid workspace name
DanielleMaywood Aug 21, 2025
fb2b8f2
fix: ensure we don't have `--` occur in fallback name
DanielleMaywood Aug 21, 2025
74bfabc
chore: increase range of generateSuffix
DanielleMaywood Aug 21, 2025
a0e41c1
fix: increase suffix length to 4 chars to reduce collision risk
DanielleMaywood Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: make generateSuffix internal
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Aug 20, 2025
commit 620a01b14e0f4d5791a18c76e9133407fc12e7d9
1 change: 0 additions & 1 deletion coderd/aitasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ func (api *API) tasksCreate(rw http.ResponseWriter, r *http.Request) {
taskName = generatedName
}
}
taskName += "-" + taskname.GenerateSuffix()

createReq := codersdk.CreateWorkspaceRequest{
Name: taskName,
Expand Down
10 changes: 6 additions & 4 deletions coderd/taskname/taskname.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ func GetAnthropicModelFromEnv() anthropic.Model {
return anthropic.Model(os.Getenv("ANTHROPIC_MODEL"))
}

// GenerateSuffix generates a random hex string between `100` and `fff`.
func GenerateSuffix() string {
// generateSuffix generates a random hex string between `100` and `fff`.
func generateSuffix() string {
numMin := 0x100
numMax := 0x1000
//nolint:gosec // We don't need a cryptographically secure random number generator for generating a task name suffix.
Expand All @@ -80,7 +80,9 @@ func GenerateSuffix() string {
}

func GenerateFallback() string {
return "task-" + strings.ReplaceAll(namesgenerator.GetRandomName(0), "_", "-")
name := strings.ReplaceAll(namesgenerator.GetRandomName(0), "_", "-")

return fmt.Sprintf("task-%s-%s", name, generateSuffix())
}

func Generate(ctx context.Context, prompt string, opts ...Option) (string, error) {
Expand Down Expand Up @@ -143,7 +145,7 @@ func Generate(ctx context.Context, prompt string, opts ...Option) (string, error
return "", ErrNoNameGenerated
}

return generatedName, nil
return fmt.Sprintf("%s-%s", generatedName, generateSuffix()), nil
}

func anthropicDataStream(ctx context.Context, client anthropic.Client, model anthropic.Model, input []aisdk.Message) (aisdk.DataStream, error) {
Expand Down
Loading