Skip to content

refactor: generate task name fallback on coderd #19447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 21, 2025
+47 −21
Merged

refactor: generate task name fallback on coderd #19447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cf1815
refactor: generate task name fallback on coderd
DanielleMaywood Aug 20, 2025
620a01b
refactor: make `generateSuffix` internal
DanielleMaywood Aug 20, 2025
a9ccd72
fix: ensure `GenerateFallback` cannot be an invalid workspace name
DanielleMaywood Aug 21, 2025
fb2b8f2
fix: ensure we don't have `--` occur in fallback name
DanielleMaywood Aug 21, 2025
74bfabc
chore: increase range of generateSuffix
DanielleMaywood Aug 21, 2025
a0e41c1
fix: increase suffix length to 4 chars to reduce collision risk
DanielleMaywood Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: ensure GenerateFallback cannot be an invalid workspace name
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Aug 21, 2025
commit a9ccd7241b9fdcdf6fb8d1e11990c85bee42a119
9 changes: 9 additions & 0 deletions coderd/taskname/taskname.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,16 @@ func generateSuffix() string {
}

func GenerateFallback() string {
// We have a 32 character limit for the name.
// We have a 5 character prefix `task-`.
// We have a 4 character suffix `-fff`.
// This leaves us with 23 characters for the middle.
//
// Unfortunately, `namesgenerator.GetRandomName(0)` will
// generate names that are longer than 23 characters, so
// we just trim these down to length.
name := strings.ReplaceAll(namesgenerator.GetRandomName(0), "_", "-")
name = name[:min(len(name), 23)]

return fmt.Sprintf("task-%s-%s", name, generateSuffix())
}
Expand Down
8 changes: 8 additions & 0 deletions coderd/taskname/taskname_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ const (
anthropicEnvVar = "ANTHROPIC_API_KEY"
)

func TestGenerateFallback(t *testing.T) {
t.Parallel()

name := taskname.GenerateFallback()
err := codersdk.NameValid(name)
require.NoErrorf(t, err, "expected fallback to be valid workspace name, instead found %s", name)
}

func TestGenerateTaskName(t *testing.T) {
t.Parallel()

Expand Down
Loading