feat(enterprise/coderd): allow system users to be added to groups #19518
Conversation
…tem user so that they can configure quotas
| DisplayName: PrebuiltWorkspacesGroupDisplayName, | ||
| OrganizationID: preset.OrganizationID, | ||
| AvatarURL: "", | ||
| QuotaAllowance: 0, // Default quota of 0, users should set this based on their needs |
There was a problem hiding this comment.
Correct me if I'm wrong, but does this mean that once this change is rolled out, no more prebuilt workspaces will be able to be provisioned until the Quota Allowance is changed? Or is the prebuilds user still part of the Everyone group?
Just asking because, in case there is a need for user action, we might need to consider this a breaking change and explicitly document the steps to set this allowance.
There was a problem hiding this comment.
the prebuilds user is still a member of the everyone group, so this shouldn't be too much of a breaking change.
There was a problem hiding this comment.
Ok, thanks for the clarification!
nit(non-blocking): It might be helpful to also add this info to the documentation, that the prebuilds user is a member of the Everyone group (which also has a quota allowance). Maybe also include a section explaining that if the quota is exceeded, the workspace build will fail and the prebuilds group quota allowance should be increased.
Co-authored-by: Susana Ferreira <susana@coder.com>
| DisplayName: PrebuiltWorkspacesGroupDisplayName, | ||
| OrganizationID: preset.OrganizationID, | ||
| AvatarURL: "", | ||
| QuotaAllowance: 0, // Default quota of 0, users should set this based on their needs |
There was a problem hiding this comment.
Ok, thanks for the clarification!
nit(non-blocking): It might be helpful to also add this info to the documentation, that the prebuilds user is a member of the Everyone group (which also has a quota allowance). Maybe also include a section explaining that if the quota is exceeded, the workspace build will fail and the prebuilds group quota allowance should be increased.
closes #18274
This pull request makes system users visible in various group related queries so that they can be added to and removed from groups. This allows system user quotas to be configured. System users are still ignored in certain queries, such as when license seat consumption is determined.
This pull request further ensures the existence of a "coder_prebuilt_workspaces" group in any organization that needs prebuilt workspaces