refactor: untangle workspace creation from http logic #19639
Merged
+106
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Aug 29, 2025
johnstcn
approved these changes
Aug 29, 2025
| } | ||
|
|
||
| type responseError struct { | ||
| status int |
There was a problem hiding this comment.
How about embedding or extending codersdk.Error instead? It already has these fields.
There was a problem hiding this comment.
I'm unsure about that for now, codersdk.Error also contains a few extra fields such as method url and Helper which I'm not sure make such sense given the context
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coder Tasks requires us to create a workspace, but we want to be able to return a
codersdk.Taskinstead of acodersdk.Workspace. This requires untanglingcreateWorkspacefrom directly writing tohttp.ResponseWriter.