Skip to content

Conversation

kacpersaw
Copy link
Contributor

Closes #19607

This pull request adds a new guide about wildcard access URLs.

@kacpersaw kacpersaw force-pushed the kacpersaw/feat-wildcard-access-url-docs branch from 3ab9114 to bc3b0f3 Compare September 5, 2025 13:07
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think from a correctness standpoint it's pretty good. Would like someone from product to approve, though

Co-authored-by: Dean Sheather <dean@deansheather.com>
@kacpersaw kacpersaw requested review from matifali and removed request for matifali September 11, 2025 10:16
@matifali matifali marked this pull request as ready for review September 11, 2025 10:45
@kacpersaw kacpersaw requested a review from matifali September 11, 2025 11:10
@matifali
Copy link
Member

@david-fraley can you please review too?

Copy link
Contributor

@david-fraley david-fraley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, but otherwise I think the page is good to go. Not gonna let those hold things up

Comment on lines 27 to 28
> [!TIP]
> For complete setup instructions, see [Wildcard Access URL Configuration](../setup/index.md#wildcard-access-url) in the main setup guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed this link, and don't think the linked guide is actually much more helpful at all. What y'all have got here is much more comprehensive, so I'd consider dropping this link. That page also links back to this one so it's a bit circular.

kacpersaw and others added 2 commits September 12, 2025 18:27
Co-authored-by: david-fraley <67079030+david-fraley@users.noreply.github.com>
@david-fraley david-fraley merged commit f9f0ebb into main Sep 12, 2025
31 checks passed
@david-fraley david-fraley deleted the kacpersaw/feat-wildcard-access-url-docs branch September 12, 2025 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document importance of configuring wildcard access URL
4 participants