-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(docs): add wildcard access url documentation page #19713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3ab9114
to
bc3b0f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think from a correctness standpoint it's pretty good. Would like someone from product to approve, though
Co-authored-by: Dean Sheather <dean@deansheather.com>
Co-authored-by: Atif Ali <atif@coder.com>
@david-fraley can you please review too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks, but otherwise I think the page is good to go. Not gonna let those hold things up
> [!TIP] | ||
> For complete setup instructions, see [Wildcard Access URL Configuration](../setup/index.md#wildcard-access-url) in the main setup guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed this link, and don't think the linked guide is actually much more helpful at all. What y'all have got here is much more comprehensive, so I'd consider dropping this link. That page also links back to this one so it's a bit circular.
Co-authored-by: david-fraley <67079030+david-fraley@users.noreply.github.com>
Closes #19607
This pull request adds a new guide about wildcard access URLs.