Remove goreleaser in favor of build scripts #2143
Conversation
There was a problem hiding this comment.
I'm not sure what pain-points we're hitting with goreleaser, but I took a surface-level look at this and it looks good!
(I think that #2202 might also be easier to implement with this refactor).
One addition that could be nice is to add checks that the required tools are available beforehand (e.g. jq, codesign, gon, etc).
scripts/publish_release.sh
Outdated
| release_notes=" | ||
| ## Changelog | ||
|
|
||
| $(git log --no-merges --pretty=format:"- %h %s" "$old_tag..$new_tag") |
There was a problem hiding this comment.
Suggestion: I think it would make the release notes easier to consume if we sorted the commits by feat/fix/etc (e.g. pipe to something like | sort -t' ' -k2).
There was a problem hiding this comment.
I've opted for trying to keep everything as close as possible to what it is with goreleaser, so instead of changing this in this PR you should open a ticket for it 😄
.github/workflows/coder.yaml
Outdated
| -covermode=atomic -coverprofile="gotests.coverage" | ||
| -coverpkg=./...,github.com/coder/coder/codersdk | ||
| -timeout=3m -count=$GOCOUNT -short -failfast | ||
| -timeout=5m -count=$GOCOUNT -short -failfast |
There was a problem hiding this comment.
non-blocking: I wonder if we should instead just use the Makefile target so we don't need to keep this in sync?
There was a problem hiding this comment.
I think this is a comment on the merge commit since I didn't touch this in my PR. Feel free to fix this in a separate PR
|
I get a weird error when I update to 0.7.2 now. Thought it's best to update here, since this PR added it, you might know the error. The ARM64 DEB binary is actually AMD64, so is there any good enough fix? |
|
@im-coder-lg what error are you getting? I just ran |
|
Oh I see the issue, the architecture in the packages are hardcoded as amd64 even though it contains the correct binary. I'll absolutely fix this |
|
Will be fixed by #2511, and once merged I will create a new release :) |
|
Fixed for arm64 and a fix for armv7 should be released later today :) |
This PR will remove goreleaser from the repository as a dependency in favor of our own build scripts. Goreleaser is presenting many issues when we try to create releases on multiple OS types with notarized binaries.
Subtasks
build_go.shscriptbuild_go_matrix.shscriptarchive.shscript to produce (and sign) an archive for the given binarypackage.shscript to produce linux package filesbuild_docker.shto build and push docker imagesbuild_docker_multiarch.shto create a multiarch manifest and push itpublish_release.shto publish a release to githubFixes #2289