chore: integrate docker into pipeline

coder · deansheather · Jun 18, 2022 · Jun 7, 2022 · Jun 8, 2022 · Jun 8, 2022
commit a0c9a964981e8b4ee26820a44fb192b917ca2836
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -58,6 +58,7 @@ jobs:
 
       - name: Build Linux and Windows Binaries
         run: |
+          set -euo pipefail
           go mod download
 
           mkdir -p ./dist
@@ -76,6 +77,37 @@ jobs:
             linux:amd64,armv7,arm64 \
             windows:amd64,arm64
 
+      - name: Build Linux Docker images
+        run: |
+          set -euo pipefail
+
+          # build and push Docker images for each architecture
+          images=()
+          for arch in amd64 armv7 arm64; do
+            img="$(
+              ./scripts/build_docker.sh \
+                ${{ !github.event.inputs.dry_run && !github.event.inputs.snapshot && '--push' }} \
+                --arch "$arch" \
+                ./dist/coder_*_linux_"$arch"
+            )"
+            images+=("$img")
+          done
+
+          # build and push multi-arch manifest
+          ./scripts/build_docker_multiarch.sh \
+            ${{ !github.event.inputs.dry_run && !github.event.inputs.snapshot && '--push' }} \
+            "${images[@]}"
+
+          # if the current version is equal to the highest (according to semver)
+          # version in the repo, also create a multi-arch image as ":latest" and
+          # push it
+          if [[ "$(git tag | grep '^v' | grep -vE '(rc|dev|-|\+|\/)' | sort -r --version-sort | head -n1)" == "v$(./scripts/version.sh)" ]]; then
+            ./scripts/build_docker_multiarch.sh \
+              --target "$(./scripts/image_tag.sh --version latest)" \
+              ${{ !github.event.inputs.dry_run && !github.event.inputs.snapshot && '--push' }} \
+              "${images[@]}"
+          fi
+
       - name: Upload binary artifacts
         uses: actions/upload-artifact@v3
         with:
@@ -120,6 +152,7 @@ jobs:
 
       - name: Install dependencies
         run: |
+          set -euo pipefail
           # The version of bash that MacOS ships with is too old
           brew install bash
 
@@ -140,6 +173,7 @@ jobs:
 
       - name: Build darwin Binaries (with signatures)
         run: |
+          set -euo pipefail
           go mod download
 
           mkdir -p ./dist

diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -1,7 +1,7 @@
 version: "3.9"
 services:
   coder:
-    image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.10}
+    image: ghcr.io/coder/coder:v${CODER_VERSION:-latest}
     ports:
       - "7080:7080"
     environment:

diff --git a/scripts/build_docker.sh b/scripts/build_docker.sh
@@ -3,7 +3,7 @@
 # This script builds a Docker image of Coder containing the given binary, for
 # the given architecture. Only linux binaries are supported at this time.
 #
-# Usage: ./build_docker.sh --arch amd64 [--version 1.2.3] [--push]
+# Usage: ./build_docker.sh --arch amd64 [--version 1.2.3] [--push] path/to/coder
 #
 # The --arch parameter is required and accepts a Golang arch specification. It
 # will be automatically mapped to a suitable architecture that Docker accepts
@@ -80,6 +80,7 @@ declare -A arch_map=(
 	[amd64]="linux/amd64"
 	[arm64]="linux/arm64"
 	[arm]="linux/arm/v7"
+	[armv7]="linux/arm/v7"
 )
 if [[ "${arch_map[$arch]+exists}" != "" ]]; then
 	arch="${arch_map[$arch]}"

diff --git a/scripts/build_docker_multiarch.sh b/scripts/build_docker_multiarch.sh
@@ -1,16 +1,20 @@
 #!/usr/bin/env bash
 
 # This script merges Coder Docker images of different architectures together
-# into the archless image tag returned by ./image_tag.sh.
+# into the specified target image+tag, or the arch-less image tag returned by
+# ./image_tag.sh.
 #
-# Usage: ./build_docker_multiarch.sh [--version 1.2.3] [--push] image1:tag1 image2:tag2
+# Usage: ./build_docker_multiarch.sh [--version 1.2.3] [--target image:tag] [--push] image1:tag1 image2:tag2
 #
 # The supplied images must already be pushed to the registry or this will fail.
 # Also, the source images cannot be in a different registry than the target
-# image generated by ./image_tag.sh.
+# image.
 #
 # If no version is specified, defaults to the version from ./version.sh.
 #
+# If no target tag is supplied, the arch-less image tag returned by
+# ./image_tag.sh will be used.
+#
 # If the --push parameter is supplied, all supplied tags will be pushed.
 #
 # Returns the merged image tag.
@@ -20,16 +24,21 @@ set -euo pipefail
 source "$(dirname "${BASH_SOURCE[0]}")/lib.sh"
 
 version=""
+target=""
 push=0
 
-args="$(getopt -o "" -l version:,push -- "$@")"
+args="$(getopt -o "" -l version:,target:,push -- "$@")"
 eval set -- "$args"
 while true; do
 	case "$1" in
 	--version)
 		version="$2"
 		shift 2
 		;;
+	--target)
+		target="$2"
+		shift 2
+		;;
 	--push)
 		push=1
 		shift
@@ -57,21 +66,24 @@ if [[ "$version" == "" ]]; then
 	version="$(execrelative ./version.sh)"
 fi
 
+if [[ "$target" == "" ]]; then
+	target="$(execrelative ./image_tag.sh --version "$version")"
+fi
+
 create_args=()
 for image_tag in "$@"; do
 	create_args+=(--amend "$image_tag")
 done
 
 # Sadly, multi-arch images don't seem to support labels.
-output_tag="$(execrelative ./image_tag.sh --version "$version")"
-log "--- Creating multi-arch Docker image ($output_tag)"
+log "--- Creating multi-arch Docker image ($target)"
 docker manifest create \
-	"$output_tag" \
+	"$target" \
 	"${create_args[@]}"
 
 if [[ "$push" == 1 ]]; then
-	log "--- Pushing multi-arch Docker image ($output_tag)"
-	docker push "$output_tag"
+	log "--- Pushing multi-arch Docker image ($target)"
+	docker manifest push "$target"
 fi
 
-echo "$output_tag"
+echo "$target"
diff --git a/scripts/image_tag.sh b/scripts/image_tag.sh
@@ -8,7 +8,8 @@
 # The --arch parameter accepts a Golang arch specification. If not specified,
 # the image tag for the multi-arch image will be returned instead.
 #
-# If no version is specified, defaults to the version from ./version.sh.
+# If no version is specified, defaults to the version from ./version.sh. If the
+# supplied version is "latest", no `v` prefix will be added to the tag.
 #
 # The returned tag will be sanitized to remove invalid characters like the plus
 # sign.
@@ -42,14 +43,17 @@ while true; do
 	esac
 done
 
-# Remove the "v" prefix.
+# Remove the "v" prefix because we don't want to add it twice.
 version="${version#v}"
 if [[ "$version" == "" ]]; then
 	version="$(execrelative ./version.sh)"
 fi
 
 image="${CODER_IMAGE_BASE:-ghcr.io/coder/coder}"
 tag="v$version"
+if [[ "$version" == "latest" ]]; then
+	tag="latest"
+fi
 if [[ "$arch" != "" ]]; then
 	tag+="-$arch"
 fi