Skip to content

feat: added include_deleted to getWorkspaceByOwnerAndName #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 8, 2022
Merged

feat: added include_deleted to getWorkspaceByOwnerAndName #2164

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
142ad4e
feat: added include_deleted
Kira-Pilot Jun 8, 2022
5c77ea4
Update coderd/workspaces.go
Kira-Pilot Jun 8, 2022
31f4013
Update coderd/workspaces.go
Kira-Pilot Jun 8, 2022
9389df3
Update coderd/workspaces.go
Kira-Pilot Jun 8, 2022
769ea99
PR feedback
Kira-Pilot Jun 8, 2022
f8a844c
wrote test, added type
Kira-Pilot Jun 8, 2022
56bceb6
Update coderd/workspaces_test.go
Kira-Pilot Jun 8, 2022
ee1f417
taking out api.ts change for now
Kira-Pilot Jun 8, 2022
28c2db6
removing api.ts changes for now
Kira-Pilot Jun 8, 2022
5381554
casing
Kira-Pilot Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR feedback
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed Jun 8, 2022
commit 769ea99882eb7ef96efb23e2f08cce2e687b53dc
1 change: 1 addition & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
"workspaceapp",
"workspaceapps",
"workspacebuilds",
"workspacename",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"wsconncache",
"xerrors",
"xstate",
Expand Down
2 changes: 1 addition & 1 deletion coderd/workspaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func (api *API) workspaceByOwnerAndName(rw http.ResponseWriter, r *http.Request)
includeDeleted, err = strconv.ParseBool(s)
if err != nil {
httpapi.Write(rw, http.StatusBadRequest, httpapi.Response{
Message: fmt.Sprintf("Invalid boolean value %q for \"include_deleted\" query param.", includeDeletedStr),
Message: fmt.Sprintf("Invalid boolean value %q for \"include_deleted\" query param.", s),
Validations: []httpapi.Error{
{Field: "include_deleted", Detail: "Must be a valid boolean"},
},
Expand Down