Skip to content

feat: added include_deleted to getWorkspaceByOwnerAndName #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 8, 2022
Merged

feat: added include_deleted to getWorkspaceByOwnerAndName #2164

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
142ad4e
feat: added include_deleted
Kira-Pilot Jun 8, 2022
5c77ea4
Update coderd/workspaces.go
Kira-Pilot Jun 8, 2022
31f4013
Update coderd/workspaces.go
Kira-Pilot Jun 8, 2022
9389df3
Update coderd/workspaces.go
Kira-Pilot Jun 8, 2022
769ea99
PR feedback
Kira-Pilot Jun 8, 2022
f8a844c
wrote test, added type
Kira-Pilot Jun 8, 2022
56bceb6
Update coderd/workspaces_test.go
Kira-Pilot Jun 8, 2022
ee1f417
taking out api.ts change for now
Kira-Pilot Jun 8, 2022
28c2db6
removing api.ts changes for now
Kira-Pilot Jun 8, 2022
5381554
casing
Kira-Pilot Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update coderd/workspaces.go 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
  • Loading branch information
@Kira-Pilot @mafredri
Kira-Pilot and mafredri authored Jun 8, 2022
commit 9389df38dfface97e2c04cbea516337035b10583
1 change: 0 additions & 1 deletion coderd/workspaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ func (api *API) workspaceByOwnerAndName(rw http.ResponseWriter, r *http.Request)
Deleted: includeDeleted,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works as intended. The param here in the SQL matches for deleted = $includeDeleted.

So if you set this to true, the workspace will not show if the workspace is deleted. We will need to update the SQL too, or just always return deleted workspaces by default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See how it's handled here:

coder/coderd/workspaces.go

Lines 57 to 62 in 454aea7

if workspace.Deleted && !showDeleted {
httpapi.Write(rw, http.StatusGone, httpapi.Response{
Message: fmt.Sprintf("Workspace %q was deleted, you can view this workspace by specifying '?deleted=true' and trying again.", workspace.ID.String()),
})
return
}

I think the deleted query param is kinda annoying as you have to know the state of the workspace to query it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emyrk Hmm, testing it in the UI seems to work.

  1. if include_deleted is false, then we never enter this code block (because errors.Is(err, sql.ErrNoRows) is false
  2. otherwise we enter this code block and try to query for a deleted workspace

In either case, if we get nothing back, we then go into the httpapi.Forbidden(rw) block below. I agree editing the SQL would also work. I just didn't know what other ramifications that would have.

Let me know if I'm misunderstanding your comment!

})
}

if errors.Is(err, sql.ErrNoRows) {
// Do not leak information if the workspace exists or not
httpapi.Forbidden(rw)
Expand Down