feat: Implement parameters list + more template list columns #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow more columns on template list
Kira-Pilot
approved these changes
Jun 15, 2022
johnstcn
approved these changes
Jun 15, 2022
cli/parameterslist.go
Outdated
Comment on lines
6
to
9
| "github.com/google/uuid" | ||
| "golang.org/x/xerrors" | ||
|
|
||
| "github.com/spf13/cobra" |
Comment on lines
+33
to
+54
| func displayParameters(filterColumns []string, params ...codersdk.Parameter) string { | ||
| tableWriter := cliui.Table() | ||
| header := table.Row{"id", "scope", "scope id", "name", "source scheme", "destination scheme", "created at", "updated at"} | ||
| tableWriter.AppendHeader(header) | ||
| tableWriter.SetColumnConfigs(cliui.FilterTableColumns(header, filterColumns)) | ||
| tableWriter.SortBy([]table.SortBy{{ | ||
| Name: "name", | ||
| }}) | ||
| for _, param := range params { | ||
| tableWriter.AppendRow(table.Row{ | ||
| param.ID.String(), | ||
| param.Scope, | ||
| param.ScopeID.String(), | ||
| param.Name, | ||
| param.SourceScheme, | ||
| param.DestinationScheme, | ||
| param.CreatedAt, | ||
| param.UpdatedAt, | ||
| }) | ||
| } | ||
| return tableWriter.Render() | ||
| } |
There was a problem hiding this comment.
I like this approach of abstracting the presentation logic from the command logic; makes it more re-usable later.
Comment on lines
+49
to
+77
| func displayTemplates(filterColumns []string, templates ...codersdk.Template) string { | ||
| tableWriter := cliui.Table() | ||
| header := table.Row{ | ||
| "Name", "Created At", "Last Updated", "Organization ID", "Provisioner", | ||
| "Active Version ID", "Used By", "Max TTL", "Min Autostart"} | ||
| tableWriter.AppendHeader(header) | ||
| tableWriter.SetColumnConfigs(cliui.FilterTableColumns(header, filterColumns)) | ||
| tableWriter.SortBy([]table.SortBy{{ | ||
| Name: "name", | ||
| }}) | ||
| for _, template := range templates { | ||
| suffix := "" | ||
| if template.WorkspaceOwnerCount != 1 { | ||
| suffix = "s" | ||
| } | ||
| tableWriter.AppendRow(table.Row{ | ||
| template.Name, | ||
| template.CreatedAt.Format("January 2, 2006"), | ||
| template.UpdatedAt.Format("January 2, 2006"), | ||
| template.OrganizationID.String(), | ||
| template.Provisioner, | ||
| template.ActiveVersionID.String(), | ||
| cliui.Styles.Fuschia.Render(fmt.Sprintf("%d developer%s", template.WorkspaceOwnerCount, suffix)), | ||
| (time.Duration(template.MaxTTLMillis) * time.Millisecond).String(), | ||
| (time.Duration(template.MinAutostartIntervalMillis) * time.Millisecond).String(), | ||
| }) | ||
| } | ||
| return tableWriter.Render() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this for debugging, figured I'd throw it in a quick branch.
What this does
Adds a way to list parameter values for a scope. Really helpful for debugging the param things I am messing with. I hide the cmd by default right now, as it lists the parameter_values, not parameter_schemes.. I think the cli should somehow distinguish the two, but don't know at the moment.
No actual values are returned from the cli, just the name + meta data.
I also added more columns templates list if they specify the columns. I needed this for debugging too.
Param list (hidden by default)
Template columns