Skip to content

fix: Start login shells on macOS and Linux #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2022
Merged

fix: Start login shells on macOS and Linux #2437

merged 3 commits into from
Jun 17, 2022

Conversation

kylecarbs
Copy link
Member

This appends -l to the shell command on macOS and Linux.
It also adds environment variable expansion to allow for
chaining from coder_agent.env.

@kylecarbs kylecarbs requested a review from mafredri June 16, 2022 20:38
@kylecarbs kylecarbs self-assigned this Jun 16, 2022
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kylecarbs kylecarbs enabled auto-merge (squash) June 16, 2022 20:51
@kylecarbs kylecarbs force-pushed the loginshell branch 2 times, most recently from 38e892a to 765c10e Compare June 16, 2022 22:18
This appends `-l` to the shell command on macOS and Linux.
It also adds environment variable expansion to allow for
chaining from `coder_agent.env`.
@kylecarbs kylecarbs merged commit b9f3fe4 into main Jun 17, 2022
@kylecarbs kylecarbs deleted the loginshell branch June 17, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants