Skip to content

fix: include architecture and version information in linux packages #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2022
Merged

fix: include architecture and version information in linux packages #2511

merged 1 commit into from
Jun 19, 2022

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Jun 19, 2022 •
edited
Loading

The nfpm.yaml correctly has environment variable templates for the architecture and version fields, but the package.sh script was never setting those environment variables. This resulted in nfpm defaulting the packages to the default arch amd64

tl;dr: the arm64 packages were incorrectly marked as amd64 packages so they couldn't be installed on arm64 🤦

Updates package.sh to set GOARCH and CODER_VERSION which are consumed by nfpm.

@deansheather deansheather requested review from coadler and ketang June 19, 2022 18:30
@deansheather deansheather mentioned this pull request Jun 19, 2022
Merged
8 tasks
@deansheather deansheather enabled auto-merge (squash) June 19, 2022 18:55
@deansheather deansheather merged commit 153ffc0 into main Jun 19, 2022
@deansheather deansheather deleted the fix-package-arch branch June 19, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

@ketang ketang Awaiting requested review from ketang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @coadler