Skip to content

improve develop.sh #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2022
Merged

improve develop.sh #2572

merged 5 commits into from
Jun 22, 2022

Conversation

johnstcn
Copy link
Member

Partially addresses #2560.

  • Running make dev now prompts you to run ./scripts/develop.sh manually, as GNU make does not appear to pass SIGINT to subprocesses.
  • Added checks to develop.sh to ensure that coderd is listening before running our initial setup steps
  • Add some more troubleshooting/debugging output to develop.sh

@johnstcn johnstcn self-assigned this Jun 22, 2022
@johnstcn johnstcn requested review from a team, deansheather and mafredri June 22, 2022 09:58
johnstcn
johnstcn commented Jun 22, 2022
View reviewed changes
mafredri
mafredri approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

@mafredri mafredri mentioned this pull request Jun 22, 2022
Closed
@johnstcn johnstcn mentioned this pull request Jun 22, 2022
Closed
@johnstcn johnstcn merged commit dc7d6de into main Jun 22, 2022
@johnstcn johnstcn deleted the cj/develop-sh-improvements branch June 22, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri