Skip to content

feat: unexpose coderdtest.NewWithAPI #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 27, 2022
Merged

feat: unexpose coderdtest.NewWithAPI #2613

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
728236f
feat: unexpose coderdtest.NewWithAPI
sreya Jun 23, 2022
0114320
fix remaining tests
sreya Jun 23, 2022
3e82608
stuff
sreya Jun 23, 2022
4a6ce0a
make gen
sreya Jun 23, 2022
4972840
lint
sreya Jun 23, 2022
b127367
some different jank
sreya Jun 24, 2022
3cae236
some small revisions
sreya Jun 24, 2022
3557eeb
add a comment to dissuade exposing API
sreya Jun 24, 2022
a2fcb79
add a gitignore
sreya Jun 24, 2022
a54a322
lint
sreya Jun 24, 2022
10127b2
pr comments
sreya Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@sreya
sreya committed Jun 27, 2022
commit a54a322d440366d63903af672862d4e516bd576a
4 changes: 2 additions & 2 deletions coderd/coderdtest/coderdtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ func NewWithProvisionerCloser(t *testing.T, options *Options) (*codersdk.Client,
options = &Options{}
}
options.IncludeProvisionerD = true
client, close := newWithCloser(t, options)
return client, close
client, closer := newWithCloser(t, options)
return client, closer
}

// newWithCloser constructs a codersdk client connected to an in-memory API instance.
Expand Down